Sign upLogin

cobudget/cobudget-api

View on GitHub
Star
app/controllers/buckets_controller.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Consider simplifying this complex logical expression.
Open

    render nothing: true, status: 403 and return unless ((current_user.is_member_of?(group) && bucket.user == current_user) || current_user.is_admin_for?(group)) && 
      (bucket.is_idea? || bucket.is_funding? || bucket.is_funded?)
Severity: Major
Found in app/controllers/buckets_controller.rb - About 1 hr to fix

    Method update has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def update
    bucket = Bucket.with_totals.find(params[:id])
    render status: 403, nothing: true and return unless bucket.is_editable_by?(current_user) && 
      (bucket.is_idea? || bucket.is_funding? || bucket.is_funded?)
    bucket.update_attributes(bucket_params_update)
    Severity: Minor
    Found in app/controllers/buckets_controller.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method archive has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def archive
    bucket = Bucket.with_totals.find(params[:id])
    group = bucket.group
    render nothing: true, status: 403 and return unless ((current_user.is_member_of?(group) && bucket.user == current_user) || current_user.is_admin_for?(group)) && 
      (bucket.is_idea? || bucket.is_funding? || bucket.is_funded?)
    Severity: Minor
    Found in app/controllers/buckets_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status