code-lever/spektrum-log

View on GitHub

Showing 3 of 3 total issues

Class Flight has 32 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Flight

      attr_reader :headers, :records

      # Creates a new flight.
Severity: Minor
Found in lib/spektrum/log/flight.rb - About 4 hrs to fix

    Method initialize has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

          def initialize(uri)
            headers = []
            headers_complete = false
            records = []
            @flights = []
    Severity: Minor
    Found in lib/spektrum/log/file.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def initialize(uri)
            headers = []
            headers_complete = false
            records = []
            @flights = []
    Severity: Minor
    Found in lib/spektrum/log/file.rb - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language