Sign upLogin

code9ty/website

View on GitHub
Star
lib/assets/AfricasTalkingGateway.rb

Summary

Maintainability
C
1 day
Test Coverage

File AfricasTalkingGateway.rb has 280 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'rubygems'
require 'net/http'
require 'uri'
require 'json'
Severity: Minor
Found in lib/assets/AfricasTalkingGateway.rb - About 2 hrs to fix

    Method sendMessage has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def sendMessage(recipients_, message_, from_ = nil, bulkSMSMode_ = 1, enqueue_ = 0, keyword_ = nil, linkId_ = nil, retryDurationInHours_ = nil)
        post_body = {
                        'username'    => @user_name, 
                        'message'     => message_, 
                        'to'          => recipients_,
    Severity: Minor
    Found in lib/assets/AfricasTalkingGateway.rb - About 1 hr to fix

      Method sendMessage has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def sendMessage(recipients_, message_, from_ = nil, bulkSMSMode_ = 1, enqueue_ = 0, keyword_ = nil, linkId_ = nil, retryDurationInHours_ = nil)
      Severity: Major
      Found in lib/assets/AfricasTalkingGateway.rb - About 1 hr to fix

        Method sendMessage has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            def sendMessage(recipients_, message_, from_ = nil, bulkSMSMode_ = 1, enqueue_ = 0, keyword_ = nil, linkId_ = nil, retryDurationInHours_ = nil)
        post_body = {
                        'username'    => @user_name, 
                        'message'     => message_, 
                        'to'          => recipients_,
        Severity: Minor
        Found in lib/assets/AfricasTalkingGateway.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def initialize(id_, text_, from_, to_, linkId_, date_)
        Severity: Minor
        Found in lib/assets/AfricasTalkingGateway.rb - About 45 mins to fix

          Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def initialize(status_, number_, amount_, requestId_, errorMessage_, discount_)
          Severity: Minor
          Found in lib/assets/AfricasTalkingGateway.rb - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                def createSubcription(phone_number_, short_code_, keyword_)
        if(phone_number_.length == 0 || short_code.length == 0 || keyword_.length == 0)
            raise AfricasTalkingGatewayException, "Please supply phone number, short code and keyword"
        end
            Severity: Major
            Found in lib/assets/AfricasTalkingGateway.rb and 1 other location - About 1 hr to fix
            lib/assets/AfricasTalkingGateway.rb on lines 175..193

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                def deleteSubcription(phone_number_, short_code_, keyword_)
        if(phone_number_.length == 0 || short_code.length == 0 || keyword_.length == 0)
            raise AfricasTalkingGatewayException, "Please supply phone number, short code and keyword"
        end
            Severity: Major
            Found in lib/assets/AfricasTalkingGateway.rb and 1 other location - About 1 hr to fix
            lib/assets/AfricasTalkingGateway.rb on lines 155..171

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status