Sign upLogin

codeRIT/hackathon_manager

View on GitHub
Star
app/controllers/manage/questionnaires_controller.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method check_in has a Cognitive Complexity of 27 (exceeds 7 allowed). Consider refactoring.
Open

  def check_in
    respond_to do |format|
      format.json do
        if params[:check_in] == "true"
          check_in_attendee
Severity: Minor
Found in app/controllers/manage/questionnaires_controller.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Perceived complexity for check_in is too high. [12/10]
Open

  def check_in
    respond_to do |format|
      format.json do
        if params[:check_in] == "true"
          check_in_attendee
Severity: Minor
Found in app/controllers/manage/questionnaires_controller.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Method check_in has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def check_in
    respond_to do |format|
      format.json do
        if params[:check_in] == "true"
          check_in_attendee
Severity: Minor
Found in app/controllers/manage/questionnaires_controller.rb - About 1 hr to fix

    Block has too many lines. [35/25]
    Open

        respond_to do |format|
      format.json do
        if params[:check_in] == "true"
          check_in_attendee
        elsif params[:check_in] == "false"
    Severity: Minor
    Found in app/controllers/manage/questionnaires_controller.rb by rubocop

    This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

    Method create has a Cognitive Complexity of 9 (exceeds 7 allowed). Consider refactoring.
    Open

      def create
    create_params = questionnaire_params
    email = create_params.delete(:email)
    create_params = convert_school_name_to_id(create_params)
    create_params = convert_boarded_bus_param(create_params)
    Severity: Minor
    Found in app/controllers/manage/questionnaires_controller.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Block has too many lines. [26/25]
    Open

          format.html do
        redirect_to_checkins = params[:redirect_to_checkins] || false
        show_redirect_path = redirect_to_checkins ? manage_checkin_path(@questionnaire) : manage_questionnaire_path(@questionnaire)
        index_redirect_path = redirect_to_checkins ? manage_checkins_path : manage_questionnaires_path
        if params[:check_in] == "true"
    Severity: Minor
    Found in app/controllers/manage/questionnaires_controller.rb by rubocop

    This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

    There are no issues that match your filters.

    Category
    Status