Sign upLogin

codeRIT/hackathon_manager

View on GitHub
Star
app/jobs/generate_data_export_job.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method generate__sponsor_dump has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def generate__sponsor_dump(data_export, attendee_type)
    print data_export.file.name

    case attendee_type
    when "rsvp_confirmed"
Severity: Major
Found in app/jobs/generate_data_export_job.rb - About 2 hrs to fix

    Block has too many lines. [50/25]
    Open

        Dir.mktmpdir("data-export") do |dir|
      folder_path = File.join(dir, data_export.file_basename)
      Dir.mkdir(folder_path)
      zipfile_name = "#{data_export.file_basename}.zip"
      zipfile_path = File.join(dir, zipfile_name)
    Severity: Minor
    Found in app/jobs/generate_data_export_job.rb by rubocop

    This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

    Use e instead of ex.
    Open

        rescue => ex
    Severity: Minor
    Found in app/jobs/generate_data_export_job.rb by rubocop

    This cop makes sure that rescued exceptions variables are named as expected.

    The PreferredName config option takes a String. It represents the required name of the variable. Its default is e.

    Example: PreferredName: e (default)

    # bad
begin
  # do something
rescue MyException => exception
  # do something
end

# good
begin
  # do something
rescue MyException => e
  # do something
end

    Example: PreferredName: exception

    # bad
begin
  # do something
rescue MyException => e
  # do something
end

# good
begin
  # do something
rescue MyException => exception
  # do something
end

    Avoid rescuing without specifying an error class.
    Open

        rescue => ex
    Severity: Minor
    Found in app/jobs/generate_data_export_job.rb by rubocop

    This cop checks for rescuing StandardError. There are two supported styles implicit and explicit. This cop will not register an offense if any error other than StandardError is specified.

    Example: EnforcedStyle: implicit

    # `implicit` will enforce using `rescue` instead of
# `rescue StandardError`.

# bad
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

    Example: EnforcedStyle: explicit (default)

    # `explicit` will enforce using `rescue StandardError`
# instead of `rescue`.

# bad
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

    Useless assignment to variable - ex.
    Open

        rescue => ex
    Severity: Minor
    Found in app/jobs/generate_data_export_job.rb by rubocop

    This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

    assigned but unused variable - foo

    Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

    Example:

    # bad

def some_method
  some_var = 1
  do_something
end

    Example:

    # good

def some_method
  some_var = 1
  do_something(some_var)
end

    Avoid comma after the last item of an array.
    Open

              q.portfolio_url,
    Severity: Minor
    Found in app/jobs/generate_data_export_job.rb by rubocop

    This cop checks for trailing comma in array literals.

    Example: EnforcedStyleForMultiline: consistent_comma

    # bad
a = [1, 2,]

# good
a = [
  1, 2,
  3,
]

# good
a = [
  1,
  2,
]

    Example: EnforcedStyleForMultiline: comma

    # bad
a = [1, 2,]

# good
a = [
  1,
  2,
]

    Example: EnforcedStyleForMultiline: no_comma (default)

    # bad
a = [1, 2,]

# good
a = [
  1,
  2
]

    There are no issues that match your filters.

    Category
    Status