Sign upLogin

codeclimate/codeclimate-bundler-audit

View on GitHub
Star
spec/cc/engine/bundler_audit/analyzer_spec.rb

Summary

Maintainability
A
0 mins
Test Coverage

Block has too many lines. [91/25]
Open

  describe Analyzer do
    describe "#run" do
      it "raises an error when no Gemfile.lock exists" do
        directory = fixture_directory("no_gemfile_lock")
Severity: Minor
Found in spec/cc/engine/bundler_audit/analyzer_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [89/25]
Open

    describe "#run" do
      it "raises an error when no Gemfile.lock exists" do
        directory = fixture_directory("no_gemfile_lock")

        expect { Analyzer.new(directory: directory).run }.
Severity: Minor
Found in spec/cc/engine/bundler_audit/analyzer_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Prefer JSON.parse over JSON.load.
Open

        stdout.string.split("\0").map { |issue| JSON.load(issue) }
Severity: Minor
Found in spec/cc/engine/bundler_audit/analyzer_spec.rb by rubocop

This cop checks for the use of JSON class methods which have potential security issues.

Autocorrect is disabled by default because it's potentially dangerous. If using a stream, like JSON.load(open('file')), it will need to call #read manually, like JSON.parse(open('file').read). If reading single values (rather than proper JSON objects), like JSON.load('false'), it will need to pass the quirks_mode: true option, like JSON.parse('false', quirks_mode: true). Other similar issues may apply.

Example:

# always offense
JSON.load("{}")
JSON.restore("{}")

# no offense
JSON.parse("{}")

Prefer JSON.parse over JSON.load.
Open

        JSON.load(body)
Severity: Minor
Found in spec/cc/engine/bundler_audit/analyzer_spec.rb by rubocop

This cop checks for the use of JSON class methods which have potential security issues.

Autocorrect is disabled by default because it's potentially dangerous. If using a stream, like JSON.load(open('file')), it will need to call #read manually, like JSON.parse(open('file').read). If reading single values (rather than proper JSON objects), like JSON.load('false'), it will need to pass the quirks_mode: true option, like JSON.parse('false', quirks_mode: true). Other similar issues may apply.

Example:

# always offense
JSON.load("{}")
JSON.restore("{}")

# no offense
JSON.parse("{}")

There are no issues that match your filters.

Category
Status