codeclimate/codeclimate-yaml

View on GitHub
lib/cc/yaml/nodes/open_mapping.rb

Summary

Maintainability
A
0 mins
Test Coverage

Unused method argument - key. If it's necessary, use _ or _key as an argument name to indicate that it won't be used. You can also write as accept_key?(*) if you want the method to accept any arguments but don't care about them.
Open

      def accept_key?(key)
Severity: Minor
Found in lib/cc/yaml/nodes/open_mapping.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Use nested module/class definitions instead of compact style.
Open

module CC::Yaml
Severity: Minor
Found in lib/cc/yaml/nodes/open_mapping.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

There are no issues that match your filters.

Category
Status