codeclimate/codeclimate-yaml

View on GitHub
lib/cc/yaml/nodes/scalar.rb

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using rescue in its modifier form.
Open

          value = cast(visitor, :str, value) rescue value
Severity: Minor
Found in lib/cc/yaml/nodes/scalar.rb by rubocop

This cop checks for uses of rescue in its modifier form.

Example:

# bad
some_method rescue handle_error

# good
begin
  some_method
rescue
  handle_error
end

Use || instead of or.
Open

        self.class.cast?(type) or type == default_type
Severity: Minor
Found in lib/cc/yaml/nodes/scalar.rb by rubocop

This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

Example: EnforcedStyle: always (default)

# bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

Example: EnforcedStyle: conditionals

# bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

Avoid the use of the case equality operator ===.
Open

        yield value if type.nil? or type === value
Severity: Minor
Found in lib/cc/yaml/nodes/scalar.rb by rubocop

This cop checks for uses of the case equality operator(===).

Example:

# bad
Array === something
(1..100) === 7
/something/ === some_string

# good
something.is_a?(Array)
(1..100).include?(7)
some_string =~ /something/

Use alias instead of alias_method in a class body.
Open

      alias_method :__getobj__, :value
Severity: Minor
Found in lib/cc/yaml/nodes/scalar.rb by rubocop

This cop enforces the use of either #alias or #alias_method depending on configuration. It also flags uses of alias :symbol rather than alias bareword.

Example: EnforcedStyle: prefer_alias (default)

# bad
alias_method :bar, :foo
alias :bar :foo

# good
alias bar foo

Example: EnforcedStyle: preferaliasmethod

# bad
alias :bar :foo
alias bar foo

# good
alias_method :bar, :foo

Use || instead of or.
Open

        yield value if type.nil? or type === value
Severity: Minor
Found in lib/cc/yaml/nodes/scalar.rb by rubocop

This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

Example: EnforcedStyle: always (default)

# bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

Example: EnforcedStyle: conditionals

# bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

Use nested module/class definitions instead of compact style.
Open

module CC::Yaml
Severity: Minor
Found in lib/cc/yaml/nodes/scalar.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

There are no issues that match your filters.

Category
Status