Sign upLogin

codeclimate/codeclimate

View on GitHub
Star
lib/cc/analyzer/container.rb

Summary

Maintainability
A
1 hr
Test Coverage
A
97%

Method run has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def run(options = [])
        started = Time.now

        command = docker_run_command(options)
        Analyzer.logger.debug("docker run: #{command.inspect}")
Severity: Minor
Found in lib/cc/analyzer/container.rb - About 1 hr to fix

    Use %i or %I for an array of symbols.
    Open

              Kernel.system("docker", "kill", @name, [:out, :err] => File::NULL)
    Severity: Minor
    Found in lib/cc/analyzer/container.rb by rubocop

    Checks for array literals made up of symbols that are not using the %i() syntax.

    Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax, perhaps because they support a version of Ruby lower than 2.0.

    Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of 3 will not enforce a style on an array of 2 or fewer elements.

    Example: EnforcedStyle: percent (default)

    # good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

    Example: EnforcedStyle: brackets

    # good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

    Omit the hash value.
    Open

              output_byte_count: output_byte_count,
    Severity: Minor
    Found in lib/cc/analyzer/container.rb by rubocop

    Checks hash literal syntax.

    It can enforce either the use of the class hash rocket syntax or the use of the newer Ruby 1.9 syntax (when applicable).

    A separate offense is registered for each problematic pair.

    The supported styles are:

    • ruby19 - forces use of the 1.9 syntax (e.g. {a: 1}) when hashes have all symbols for keys
    • hash_rockets - forces use of hash rockets for all hashes
    • nomixedkeys - simply checks for hashes with mixed syntaxes
    • ruby19nomixed_keys - forces use of ruby 1.9 syntax and forbids mixed syntax hashes

    This cop has EnforcedShorthandSyntax option. It can enforce either the use of the explicit hash value syntax or the use of Ruby 3.1's hash value shorthand syntax.

    The supported styles are:

    • always - forces use of the 3.1 syntax (e.g. {foo:})
    • never - forces use of explicit hash literal value
    • either - accepts both shorthand and explicit use of hash literal value

    Example: EnforcedStyle: ruby19 (default)

    # bad
{:a => 2}
{b: 1, :c => 2}

# good
{a: 2, b: 1}
{:c => 2, 'd' => 2} # acceptable since 'd' isn't a symbol
{d: 1, 'e' => 2} # technically not forbidden

    Example: EnforcedStyle: hash_rockets

    # bad
{a: 1, b: 2}
{c: 1, 'd' => 5}

# good
{:a => 1, :b => 2}

    Example: EnforcedStyle: nomixedkeys

    # bad
{:a => 1, b: 2}
{c: 1, 'd' => 2}

# good
{:a => 1, :b => 2}
{c: 1, d: 2}

    Example: EnforcedStyle: ruby19nomixed_keys

    # bad
{:a => 1, :b => 2}
{c: 2, 'd' => 3} # should just use hash rockets

# good
{a: 1, b: 2}
{:c => 3, 'd' => 4}

    Example: EnforcedShorthandSyntax: always (default)

    # bad
{foo: foo, bar: bar}

# good
{foo:, bar:}

    Example: EnforcedShorthandSyntax: never

    # bad
{foo:, bar:}

# good
{foo: foo, bar: bar}

    Example: EnforcedShorthandSyntax: either

    # good
{foo: foo, bar: bar}

# good
{foo:, bar:}

    Omit the hash value.
    Open

              duration: duration,
    Severity: Minor
    Found in lib/cc/analyzer/container.rb by rubocop

    Checks hash literal syntax.

    It can enforce either the use of the class hash rocket syntax or the use of the newer Ruby 1.9 syntax (when applicable).

    A separate offense is registered for each problematic pair.

    The supported styles are:

    • ruby19 - forces use of the 1.9 syntax (e.g. {a: 1}) when hashes have all symbols for keys
    • hash_rockets - forces use of hash rockets for all hashes
    • nomixedkeys - simply checks for hashes with mixed syntaxes
    • ruby19nomixed_keys - forces use of ruby 1.9 syntax and forbids mixed syntax hashes

    This cop has EnforcedShorthandSyntax option. It can enforce either the use of the explicit hash value syntax or the use of Ruby 3.1's hash value shorthand syntax.

    The supported styles are:

    • always - forces use of the 3.1 syntax (e.g. {foo:})
    • never - forces use of explicit hash literal value
    • either - accepts both shorthand and explicit use of hash literal value

    Example: EnforcedStyle: ruby19 (default)

    # bad
{:a => 2}
{b: 1, :c => 2}

# good
{a: 2, b: 1}
{:c => 2, 'd' => 2} # acceptable since 'd' isn't a symbol
{d: 1, 'e' => 2} # technically not forbidden

    Example: EnforcedStyle: hash_rockets

    # bad
{a: 1, b: 2}
{c: 1, 'd' => 5}

# good
{:a => 1, :b => 2}

    Example: EnforcedStyle: nomixedkeys

    # bad
{:a => 1, b: 2}
{c: 1, 'd' => 2}

# good
{:a => 1, :b => 2}
{c: 1, d: 2}

    Example: EnforcedStyle: ruby19nomixed_keys

    # bad
{:a => 1, :b => 2}
{c: 2, 'd' => 3} # should just use hash rockets

# good
{a: 1, b: 2}
{:c => 3, 'd' => 4}

    Example: EnforcedShorthandSyntax: always (default)

    # bad
{foo: foo, bar: bar}

# good
{foo:, bar:}

    Example: EnforcedShorthandSyntax: never

    # bad
{foo:, bar:}

# good
{foo: foo, bar: bar}

    Example: EnforcedShorthandSyntax: either

    # good
{foo: foo, bar: bar}

# good
{foo:, bar:}

    Use %i or %I for an array of symbols.
    Open

              Kernel.system("docker", "wait", @name, [:out, :err] => File::NULL)
    Severity: Minor
    Found in lib/cc/analyzer/container.rb by rubocop

    Checks for array literals made up of symbols that are not using the %i() syntax.

    Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax, perhaps because they support a version of Ruby lower than 2.0.

    Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of 3 will not enforce a style on an array of 2 or fewer elements.

    Example: EnforcedStyle: percent (default)

    # good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

    Example: EnforcedStyle: brackets

    # good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

    There are no issues that match your filters.

    Category
    Status