codeclimate/minidoc

View on GitHub
lib/minidoc.rb

Summary

Maintainability
B
4 hrs
Test Coverage
A
95%

Class has too many lines. [162/100]
Open

class Minidoc
  require "minidoc/associations"
  require "minidoc/connection"
  require "minidoc/counters"
  require "minidoc/finders"
Severity: Minor
Found in lib/minidoc.rb by rubocop

This cop checks if the length a class exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Class Minidoc has 29 methods (exceeds 20 allowed). Consider refactoring.
Open

class Minidoc
  require "minidoc/associations"
  require "minidoc/connection"
  require "minidoc/counters"
  require "minidoc/finders"
Severity: Minor
Found in lib/minidoc.rb - About 3 hrs to fix

    Method create_or_update has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def create_or_update
        new_record? ? create : update
        @new_record = false
        true
      rescue Mongo::Error::OperationFailure => exception
    Severity: Minor
    Found in lib/minidoc.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Indent access modifiers like private.
    Open

    private
    Severity: Minor
    Found in lib/minidoc.rb by rubocop

    Modifiers should be indented as deep as method definitions, or as deep as the class/module keyword, depending on configuration.

    Example: EnforcedStyle: indent (default)

    # bad
    class Plumbus
    private
      def smooth; end
    end
    
    # good
    class Plumbus
      private
      def smooth; end
    end

    Example: EnforcedStyle: outdent

    # bad
    class Plumbus
      private
      def smooth; end
    end
    
    # good
    class Plumbus
    private
      def smooth; end
    end

    Redundant curly braces around a hash parameter.
    Open

        self.class.collection.update_one({ _id: id }, { "$set" => attributes.except(:_id) })
    Severity: Minor
    Found in lib/minidoc.rb by rubocop

    This cop checks for braces around the last parameter in a method call if the last parameter is a hash. It supports braces, no_braces and context_dependent styles.

    Example: EnforcedStyle: braces

    # The `braces` style enforces braces around all method
    # parameters that are hashes.
    
    # bad
    some_method(x, y, a: 1, b: 2)
    
    # good
    some_method(x, y, {a: 1, b: 2})

    Example: EnforcedStyle: no_braces (default)

    # The `no_braces` style checks that the last parameter doesn't
    # have braces around it.
    
    # bad
    some_method(x, y, {a: 1, b: 2})
    
    # good
    some_method(x, y, a: 1, b: 2)

    Example: EnforcedStyle: context_dependent

    # The `context_dependent` style checks that the last parameter
    # doesn't have braces around it, but requires braces if the
    # second to last parameter is also a hash literal.
    
    # bad
    some_method(x, y, {a: 1, b: 2})
    some_method(x, y, {a: 1, b: 2}, a: 1, b: 2)
    
    # good
    some_method(x, y, a: 1, b: 2)
    some_method(x, y, {a: 1, b: 2}, {a: 1, b: 2})

    Redundant self detected.
    Open

        new_object = self.class.find(self.id) or raise DocumentNotFoundError
    Severity: Minor
    Found in lib/minidoc.rb by rubocop

    This cop checks for redundant uses of self.

    The usage of self is only needed when:

    • Sending a message to same object with zero arguments in presence of a method name clash with an argument or a local variable.

    • Calling an attribute writer to prevent an local variable assignment.

    Note, with using explicit self you can only send messages with public or protected scope, you cannot send private messages this way.

    Note we allow uses of self with operators because it would be awkward otherwise.

    Example:

    # bad
    def foo(bar)
      self.baz
    end
    
    # good
    def foo(bar)
      self.bar  # Resolves name clash with the argument.
    end
    
    def foo
      bar = 1
      self.bar  # Resolves name clash with the local variable.
    end
    
    def foo
      %w[x y z].select do |bar|
        self.bar == bar  # Resolves name clash with argument of the block.
      end
    end

    Missing magic comment # frozen_string_literal: true.
    Open

    require "mongo"
    Severity: Minor
    Found in lib/minidoc.rb by rubocop

    This cop is designed to help upgrade to Ruby 3.0. It will add the comment # frozen_string_literal: true to the top of files to enable frozen string literals. Frozen string literals may be default in Ruby 3.0. The comment will be added below a shebang and encoding comment. The frozen string literal comment is only valid in Ruby 2.3+.

    Example: EnforcedStyle: when_needed (default)

    # The `when_needed` style will add the frozen string literal comment
    # to files only when the `TargetRubyVersion` is set to 2.3+.
    # bad
    module Foo
      # ...
    end
    
    # good
    # frozen_string_literal: true
    
    module Foo
      # ...
    end

    Example: EnforcedStyle: always

    # The `always` style will always add the frozen string literal comment
    # to a file, regardless of the Ruby version or if `freeze` or `<<` are
    # called on a string literal.
    # bad
    module Bar
      # ...
    end
    
    # good
    # frozen_string_literal: true
    
    module Bar
      # ...
    end

    Example: EnforcedStyle: never

    # The `never` will enforce that the frozen string literal comment does
    # not exist in a file.
    # bad
    # frozen_string_literal: true
    
    module Baz
      # ...
    end
    
    # good
    module Baz
      # ...
    end

    Redundant self detected.
    Open

        other.is_a?(self.class) && self.id && self.id == other.id
    Severity: Minor
    Found in lib/minidoc.rb by rubocop

    This cop checks for redundant uses of self.

    The usage of self is only needed when:

    • Sending a message to same object with zero arguments in presence of a method name clash with an argument or a local variable.

    • Calling an attribute writer to prevent an local variable assignment.

    Note, with using explicit self you can only send messages with public or protected scope, you cannot send private messages this way.

    Note we allow uses of self with operators because it would be awkward otherwise.

    Example:

    # bad
    def foo(bar)
      self.baz
    end
    
    # good
    def foo(bar)
      self.bar  # Resolves name clash with the argument.
    end
    
    def foo
      bar = 1
      self.bar  # Resolves name clash with the local variable.
    end
    
    def foo
      %w[x y z].select do |bar|
        self.bar == bar  # Resolves name clash with argument of the block.
      end
    end

    Redundant self detected.
    Open

        other.is_a?(self.class) && self.id && self.id == other.id
    Severity: Minor
    Found in lib/minidoc.rb by rubocop

    This cop checks for redundant uses of self.

    The usage of self is only needed when:

    • Sending a message to same object with zero arguments in presence of a method name clash with an argument or a local variable.

    • Calling an attribute writer to prevent an local variable assignment.

    Note, with using explicit self you can only send messages with public or protected scope, you cannot send private messages this way.

    Note we allow uses of self with operators because it would be awkward otherwise.

    Example:

    # bad
    def foo(bar)
      self.baz
    end
    
    # good
    def foo(bar)
      self.bar  # Resolves name clash with the argument.
    end
    
    def foo
      bar = 1
      self.bar  # Resolves name clash with the local variable.
    end
    
    def foo
      %w[x y z].select do |bar|
        self.bar == bar  # Resolves name clash with argument of the block.
      end
    end

    Provide an exception class and message as arguments to raise.
    Open

        valid? ? create_or_update : raise(RecordInvalid.new(self))
    Severity: Minor
    Found in lib/minidoc.rb by rubocop

    This cop checks the args passed to fail and raise. For exploded style (default), it recommends passing the exception class and message to raise, rather than construct an instance of the error. It will still allow passing just a message, or the construction of an error with more than one argument.

    The exploded style works identically, but with the addition that it will also suggest constructing error objects when the exception is passed multiple arguments.

    Example: EnforcedStyle: exploded (default)

    # bad
    raise StandardError.new("message")
    
    # good
    raise StandardError, "message"
    fail "message"
    raise MyCustomError.new(arg1, arg2, arg3)
    raise MyKwArgError.new(key1: val1, key2: val2)

    Example: EnforcedStyle: compact

    # bad
    raise StandardError, "message"
    raise RuntimeError, arg1, arg2, arg3
    
    # good
    raise StandardError.new("message")
    raise MyCustomError.new(arg1, arg2, arg3)
    fail "message"

    There are no issues that match your filters.

    Category
    Status