codeclimate/php-test-reporter

View on GitHub

Showing 19 of 19 total issues

Method sendWithCurl has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function sendWithCurl($url, $payload)
    {
        $response = new \stdClass;
        $curl     = curl_init($url);
        curl_setopt($curl, CURLOPT_HEADER, true);
Severity: Minor
Found in src/TestReporter/ApiClient.php - About 1 hr to fix

    Method infoFrom has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function infoFrom(array $server)
        {
            if (isset($server["TRAVIS"])) {
                return $this->travisProperties($server);
            }
    Severity: Minor
    Found in src/TestReporter/Entity/CiInfo.php - About 1 hr to fix

      Method send has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function send(Entity\JsonFile $json)
          {
              $response = new \stdClass;
              $payload  = (string)$json;
              $options  = array(
      Severity: Minor
      Found in src/TestReporter/ApiClient.php - About 1 hr to fix

        Function infoFrom has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            private function infoFrom(array $server)
            {
                if (isset($server["TRAVIS"])) {
                    return $this->travisProperties($server);
                }
        Severity: Minor
        Found in src/TestReporter/Entity/CiInfo.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method execute has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function execute(InputInterface $input, OutputInterface $output)
            {
                $logger  = new ConsoleLogger($output);
                $updater = new Updater(null, false, Updater::STRATEGY_GITHUB);
        
        
        Severity: Minor
        Found in src/ConsoleCommands/SelfUpdateCommand.php - About 1 hr to fix

          Avoid too many return statements within this method.
          Open

                      return $this->gitlabCiProperties($server);
          Severity: Major
          Found in src/TestReporter/Entity/CiInfo.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return array();
            Severity: Major
            Found in src/TestReporter/Entity/CiInfo.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return $this->tddiumProperties($server);
              Severity: Major
              Found in src/TestReporter/Entity/CiInfo.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return $this->buildkiteProperties($server);
                Severity: Major
                Found in src/TestReporter/Entity/CiInfo.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return $this->werckerProperties($server);
                  Severity: Major
                  Found in src/TestReporter/Entity/CiInfo.php - About 30 mins to fix

                    Remove error control operator '@' on line 50.
                    Open

                        public function send(Entity\JsonFile $json)
                        {
                            $response = new \stdClass;
                            $payload  = (string)$json;
                            $options  = array(
                    Severity: Minor
                    Found in src/TestReporter/ApiClient.php by phpmd

                    ErrorControlOperator

                    Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

                    Example

                    function foo($filePath) {
                        $file = @fopen($filPath); // hides exceptions
                        $key = @$array[$notExistingKey]; // assigns null to $key
                    }

                    Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

                    Missing class import via use statement (line '32', column '25').
                    Open

                            $response = new \stdClass;
                    Severity: Minor
                    Found in src/TestReporter/ApiClient.php by phpmd

                    MissingImport

                    Since: 2.7.0

                    Importing all external classes in a file through use statements makes them clearly visible.

                    Example

                    function make() {
                        return new \stdClass();
                    }

                    Source http://phpmd.org/rules/cleancode.html#MissingImport

                    Missing class import via use statement (line '76', column '25').
                    Open

                            $response = new \stdClass;
                    Severity: Minor
                    Found in src/TestReporter/ApiClient.php by phpmd

                    MissingImport

                    Since: 2.7.0

                    Importing all external classes in a file through use statements makes them clearly visible.

                    Example

                    function make() {
                        return new \stdClass();
                    }

                    Source http://phpmd.org/rules/cleancode.html#MissingImport

                    Avoid too many return statements within this method.
                    Open

                                return $this->codeshipProperties($server);
                    Severity: Major
                    Found in src/TestReporter/Entity/CiInfo.php - About 30 mins to fix

                      Function execute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          protected function execute(InputInterface $input, OutputInterface $output)
                          {
                              $logger  = new ConsoleLogger($output);
                              $updater = new Updater(null, false, Updater::STRATEGY_GITHUB);
                      
                      
                      Severity: Minor
                      Found in src/ConsoleCommands/SelfUpdateCommand.php - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Avoid unused parameters such as '$input'.
                      Open

                          protected function getCommandName(InputInterface $input)
                      Severity: Minor
                      Found in src/Application.php by phpmd

                      UnusedFormalParameter

                      Since: 0.2

                      Avoid passing parameters to methods or constructors and then not using those parameters.

                      Example

                      class Foo
                      {
                          private function bar($howdy)
                          {
                              // $howdy is not used
                          }
                      }

                      Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

                      Avoid assigning values to variables in if clauses and the like (line '50', column '13').
                      Open

                          public function send(Entity\JsonFile $json)
                          {
                              $response = new \stdClass;
                              $payload  = (string)$json;
                              $options  = array(
                      Severity: Minor
                      Found in src/TestReporter/ApiClient.php by phpmd

                      IfStatementAssignment

                      Since: 2.7.0

                      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                      Example

                      class Foo
                      {
                          public function bar($flag)
                          {
                              if ($foo = 'bar') { // possible typo
                                  // ...
                              }
                              if ($baz = 0) { // always false
                                  // ...
                              }
                          }
                      }

                      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                      The method infoFrom() has an NPath complexity of 768. The configured NPath complexity threshold is 200.
                      Open

                          private function infoFrom(array $server)
                          {
                              if (isset($server["TRAVIS"])) {
                                  return $this->travisProperties($server);
                              }
                      Severity: Minor
                      Found in src/TestReporter/Entity/CiInfo.php by phpmd

                      NPathComplexity

                      Since: 0.1

                      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                      Example

                      class Foo {
                          function bar() {
                              // lots of complicated code
                          }
                      }

                      Source https://phpmd.org/rules/codesize.html#npathcomplexity

                      The method infoFrom() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
                      Open

                          private function infoFrom(array $server)
                          {
                              if (isset($server["TRAVIS"])) {
                                  return $this->travisProperties($server);
                              }
                      Severity: Minor
                      Found in src/TestReporter/Entity/CiInfo.php by phpmd

                      CyclomaticComplexity

                      Since: 0.1

                      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                      Example

                      // Cyclomatic Complexity = 11
                      class Foo {
                      1   public function example() {
                      2       if ($a == $b) {
                      3           if ($a1 == $b1) {
                                      fiddle();
                      4           } elseif ($a2 == $b2) {
                                      fiddle();
                                  } else {
                                      fiddle();
                                  }
                      5       } elseif ($c == $d) {
                      6           while ($c == $d) {
                                      fiddle();
                                  }
                      7        } elseif ($e == $f) {
                      8           for ($n = 0; $n < $h; $n++) {
                                      fiddle();
                                  }
                              } else {
                                  switch ($z) {
                      9               case 1:
                                          fiddle();
                                          break;
                      10              case 2:
                                          fiddle();
                                          break;
                      11              case 3:
                                          fiddle();
                                          break;
                                      default:
                                          fiddle();
                                          break;
                                  }
                              }
                          }
                      }

                      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                      Severity
                      Category
                      Status
                      Source
                      Language