codeclimate/ruby-test-reporter

View on GitHub

Showing 25 of 25 total issues

Method has too many lines. [96/10]
Open

      def self.service_data(env = ENV)
        if env["TRAVIS"]
          {
            name:             "travis-ci",
            branch:           env["TRAVIS_BRANCH"],

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [38/10]
Open

      def to_payload(result)
        totals = Hash.new(0)
        source_files = result.files.map do |file|
          totals[:total] += file.lines.count
          totals[:covered] += file.covered_lines.count

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method service_data has 96 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def self.service_data(env = ENV)
        if env["TRAVIS"]
          {
            name:             "travis-ci",
            branch:           env["TRAVIS_BRANCH"],
Severity: Major
Found in lib/code_climate/test_reporter/ci.rb - About 3 hrs to fix

    Method has too many lines. [26/10]
    Open

          def batch_post_results(files)
            uri = URI.parse("#{host}/test_reports/batch")
            http = http_client(uri)
    
            boundary = SecureRandom.uuid

    This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

    Method has too many lines. [18/10]
    Open

          def message
            parts = []
            parts << "Code Climate encountered an exception: #{exception_class}"
            if http_stubbing_exception
              message = http_stubbing_exception.new

    This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

    Cyclomatic complexity for service_data is too high. [13/6]
    Open

          def self.service_data(env = ENV)
            if env["TRAVIS"]
              {
                name:             "travis-ci",
                branch:           env["TRAVIS_BRANCH"],

    This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

    An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

    Method has too many lines. [17/10]
    Open

          def post_results(result)
            uri = URI.parse("#{host}/test_reports")
            http = http_client(uri)
    
            request = Net::HTTP::Post.new(uri.path)

    This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

    Perceived complexity for service_data is too high. [14/7]
    Open

          def self.service_data(env = ENV)
            if env["TRAVIS"]
              {
                name:             "travis-ci",
                branch:           env["TRAVIS_BRANCH"],

    This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

    Example:

    def my_method                   # 1
      if cond                       # 1
        case var                    # 2 (0.8 + 4 * 0.2, rounded)
        when 1 then func_one
        when 2 then func_two
        when 3 then func_three
        when 4..10 then func_other
        end
      else                          # 1
        do_something until a && b   # 2
      end                           # ===
    end                             # 7 complexity points

    Method has too many lines. [12/10]
    Open

          def format(results)
            simplecov_results = results.map do |command_name, data|
              SimpleCov::Result.from_hash(command_name => data)
            end
    
    

    This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

    Method service_data has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

          def self.service_data(env = ENV)
            if env["TRAVIS"]
              {
                name:             "travis-ci",
                branch:           env["TRAVIS_BRANCH"],
    Severity: Minor
    Found in lib/code_climate/test_reporter/ci.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method to_payload has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def to_payload(result)
            totals = Hash.new(0)
            source_files = result.files.map do |file|
              totals[:total] += file.lines.count
              totals[:covered] += file.covered_lines.count
    Severity: Minor
    Found in lib/code_climate/test_reporter/formatter.rb - About 1 hr to fix

      Method validate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

            def validate
              raise InvalidPayload, "A git commit sha was not found in the test report payload" unless commit_sha
              raise InvalidPayload, "A git commit timestamp was not found in the test report payload" unless committed_at
              raise InvalidPayload, "A run at timestamp was not found in the test report payload" unless run_at
              raise InvalidPayload, "No source files were found in the test report payload" unless source_files?
      Severity: Minor
      Found in lib/code_climate/test_reporter/payload_validator.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method batch_post_results has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def batch_post_results(files)
              uri = URI.parse("#{host}/test_reports/batch")
              http = http_client(uri)
      
              boundary = SecureRandom.uuid
      Severity: Minor
      Found in lib/code_climate/test_reporter/client.rb - About 1 hr to fix

        Avoid the use of double negation (!!).
        Open

              @environment_variable_set = !!ENV["CODECLIMATE_REPO_TOKEN"]
        Severity: Minor
        Found in lib/code_climate/test_reporter.rb by rubocop

        This cop checks for uses of double negation (!!) to convert something to a boolean value. As this is both cryptic and usually redundant, it should be avoided.

        Example:

        # bad
        !!something
        
        # good
        !something.nil?

        Please, note that when something is a boolean value !!something and !something.nil? are not the same thing. As you're unlikely to write code that can accept values of any type this is rarely a problem in practice.

        Use warn instead of $stderr.puts to allow such output to be disabled.
        Open

          $stderr.puts "Cannot batch post - environment variable CODECLIMATE_REPO_TOKEN must be set."
        Severity: Minor
        Found in bin/cc-tddium-post-worker by rubocop

        This cop identifies places where $stderr.puts can be replaced by warn. The latter has the advantage of easily being disabled by, e.g. the -W0 interpreter flag, or setting $VERBOSE to nil.

        Example:

        # bad
        $stderr.puts('hello')
        
        # good
        warn('hello')

        Replace class var @@configuration with a class instance var.
        Open

            @@configuration = nil

        This cop checks for uses of class variables. Offenses are signaled only on assignment to class variables to reduce the number of offenses that would be reported.

        Use meaningful heredoc delimiters.
        Open

            EOS
        Severity: Minor
        Found in lib/code_climate/test_reporter.rb by rubocop

        This cop checks that your heredocs are using meaningful delimiters. By default it disallows END and EO*, and can be configured through blacklisting additional delimiters.

        Example:

        # good
        <<-SQL
          SELECT * FROM foo
        SQL
        
        # bad
        <<-END
          SELECT * FROM foo
        END
        
        # bad
        <<-EOS
          SELECT * FROM foo
        EOS

        Empty line detected around arguments.
        Open

        
          Please visit https://docs.codeclimate.com/v1.0/docs/configuring-test-coverage
        Severity: Minor
        Found in codeclimate-test-reporter.gemspec by rubocop

        This cops checks if empty lines exist around the arguments of a method invocation.

        Example:

        # bad
        do_something(
          foo
        
        )
        
        process(bar,
        
                baz: qux,
                thud: fred)
        
        some_method(
        
          [1,2,3],
          x: y
        )
        
        # good
        do_something(
          foo
        )
        
        process(bar,
                baz: qux,
                thud: fred)
        
        some_method(
          [1,2,3],
          x: y
        )

        Use %q only for strings that contain both single quotes and double quotes.
        Open

          spec.post_install_message = %q(
          Code Climate's codeclimate-test-reporter gem has been deprecated in favor of
          our language-agnostic unified test reporter. The new test reporter is faster,
          distributed as a static binary so dependency conflicts never occur, and
          supports parallelized CI builds & multi-language CI configurations.
        Severity: Minor
        Found in codeclimate-test-reporter.gemspec by rubocop

        The name of this source file (codeclimate-test-reporter.rb) should use snake_case.
        Open

        require "code_climate/test_reporter"
        Severity: Minor
        Found in lib/codeclimate-test-reporter.rb by rubocop

        This cop makes sure that Ruby source files have snake_case names. Ruby scripts (i.e. source files with a shebang in the first line) are ignored.

        Example:

        # bad
        lib/layoutManager.rb
        
        anything/usingCamelCase
        
        # good
        lib/layout_manager.rb
        
        anything/using_snake_case.rake
        Severity
        Category
        Status
        Source
        Language