Sign upLogin

codeforamerica/clientcomm-rails

View on GitHub
Star
app/controllers/clients_controller.rb

Summary

Maintainability
A
50 mins
Test Coverage

Method handle_existing_relationship has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def handle_existing_relationship
    return unless @client.errors.added?(:phone_number, :taken)
    return if @conflicting_user

    existing_relationship = current_user.reporting_relationships.find_by(client: @existing_client)
Severity: Minor
Found in app/controllers/clients_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method handle_new_relationship_with_existing_client has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def handle_new_relationship_with_existing_client
    return unless @client.errors.added?(:phone_number, :taken)
    return if @conflicting_user
    return if current_user.clients.include?(@existing_client)
Severity: Minor
Found in app/controllers/clients_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status