codeforamerica/intake

View on GitHub
features/steps/county_applications_steps.py

Summary

Maintainability
C
7 hrs
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

@then('it displays basic answers')
@then('it displays basic answers for "{applicant_name}"')
def test_displays_basic_answers(context, applicant_name="Jane Doe"):
    first_name, last_name = applicant_name.split(' ')
    context.execute_steps('''
Severity: Major
Found in features/steps/county_applications_steps.py and 2 other locations - About 2 hrs to fix
features/steps/county_applications_steps.py on lines 42..68
features/steps/county_applications_steps.py on lines 71..82

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

@when(
    '"{applicant_name}" fills out a county application form with basic answers'
)
@when('applicant fills out a county application form with basic answers')
def input_basic_answers(context, applicant_name="Jane Doe"):
Severity: Major
Found in features/steps/county_applications_steps.py and 2 other locations - About 2 hrs to fix
features/steps/county_applications_steps.py on lines 71..82
features/steps/county_applications_steps.py on lines 85..102

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

@when('"{applicant_name}" fills out county not listed form fields')
@when('applicant fills out county not listed form fields')
def fill_county_not_listed_fields(context, applicant_name="Jane Doe"):
    first_name, last_name = applicant_name.split(' ')
    context.execute_steps('''
Severity: Major
Found in features/steps/county_applications_steps.py and 2 other locations - About 2 hrs to fix
features/steps/county_applications_steps.py on lines 42..68
features/steps/county_applications_steps.py on lines 85..102

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status