Sign upLogin

codeforamerica/intake

View on GitHub
Star

Showing 146 of 168 total issues

Function get_contact_info has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def get_contact_info(self):
        """Returns a dictionary of contact information structured to
        be valid for intake.fields.ContactInfoJSONField
        """
        info = {}
Severity: Minor
Found in intake/models/form_submission.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_context_data has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def get_context_data(self, *args, **kwargs):
        context = super().get_context_data(*args, **kwargs)
        self.submission = self.submissions[0]
        display_form, letter_display = \
            DisplayFormService.get_display_form_for_user_and_submission(
Severity: Minor
Found in intake/views/app_detail_views.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

TODO found
Open

        # TODO: make this less nested
Severity: Minor
Found in intake/pdfparser.py by fixme

TODO found
Open

        # TODO: add an event to trigger, and try to log in mixpanel that
Severity: Minor
Found in phone/views.py by fixme

TODO found
Open

    # TODO: Fix whatever is causing circular imports.
Severity: Minor
Found in user_accounts/tasks.py by fixme

TODO found
Open

      {# TODO: create more notification objects #}
Severity: Minor
Found in templates/includes/application_event.jinja by fixme
Severity
Category
Status
Source
Language