Sign upLogin

codeforamerica/intake

View on GitHub
Star
printing/pdf_form_display.py

Summary

Maintainability
A
3 hrs
Test Coverage

File pdf_form_display.py has 304 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import io
import string
import collections

from django.conf import settings
Severity: Minor
Found in printing/pdf_form_display.py - About 3 hrs to fix

    Cyclomatic complexity is too high in function u. (6)
    Open

    def u(amount):
    units = ''.join([c for c in amount if c in string.ascii_letters])
    units = units.lower()
    number_string = ''.join([c for c in amount if c in digit_chars])
    if '.' in number_string:
    Severity: Minor
    Found in printing/pdf_form_display.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function Style has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def Style(name, font='Helvetica', size=12, leading=None, color=colors.black):
    Severity: Minor
    Found in printing/pdf_form_display.py - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status