codeforamerica/michigan-benefits

View on GitHub
app/models/concerns/multiparameter_attribute_assignment.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method execute_callstack_for_multiparameter_attributes has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def execute_callstack_for_multiparameter_attributes(callstack)
    # Disabling Rubcop below because Brakeman is failing to parse the
    #  when we remove the 'begin' keyword
    # rubocop:disable Style/RedundantBegin
    errors = []
Severity: Minor
Found in app/models/concerns/multiparameter_attribute_assignment.rb - About 1 hr to fix

    Method execute_callstack_for_multiparameter_attributes has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def execute_callstack_for_multiparameter_attributes(callstack)
        # Disabling Rubcop below because Brakeman is failing to parse the
        #  when we remove the 'begin' keyword
        # rubocop:disable Style/RedundantBegin
        errors = []
    Severity: Minor
    Found in app/models/concerns/multiparameter_attribute_assignment.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status