Sign upLogin

codeforamerica/michigan-benefits

View on GitHub
Star
app/models/dhs1426_pdf.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Class Dhs1426Pdf has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

class Dhs1426Pdf
  PDF_DIRECTORY = "app/lib/pdfs".freeze
  SOURCE_PDF = "#{PDF_DIRECTORY}/DHS_1426.pdf".freeze
  COVERSHEET_PDF = "#{PDF_DIRECTORY}/DHS_1426_cover_letter.pdf".freeze
  STEP_2_ADDITIONAL_MEMBER_PDF =
Severity: Minor
Found in app/models/dhs1426_pdf.rb - About 2 hrs to fix

    Avoid comma after the last item of an array.
    Open

          verification_documents,
    Severity: Minor
    Found in app/models/dhs1426_pdf.rb by rubocop

    This cop checks for trailing comma in array and hash literals.

    Example: EnforcedStyleForMultiline: consistent_comma

    # bad
a = [1, 2,]

# good
a = [
  1, 2,
  3,
]

# good
a = [
  1,
  2,
]

    Example: EnforcedStyleForMultiline: comma

    # bad
a = [1, 2,]

# good
a = [
  1,
  2,
]

    Example: EnforcedStyleForMultiline: no_comma (default)

    # bad
a = [1, 2,]

# good
a = [
  1,
  2
]

    Avoid comma after the last item of an array.
    Open

          { member: second_member, position: "second" },
    Severity: Minor
    Found in app/models/dhs1426_pdf.rb by rubocop

    This cop checks for trailing comma in array and hash literals.

    Example: EnforcedStyleForMultiline: consistent_comma

    # bad
a = [1, 2,]

# good
a = [
  1, 2,
  3,
]

# good
a = [
  1,
  2,
]

    Example: EnforcedStyleForMultiline: comma

    # bad
a = [1, 2,]

# good
a = [
  1,
  2,
]

    Example: EnforcedStyleForMultiline: no_comma (default)

    # bad
a = [1, 2,]

# good
a = [
  1,
  2
]

    There are no issues that match your filters.

    Category
    Status