codeforamerica/michigan-benefits

Method supplement_attributes has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def supplement_attributes
    {
      anyone_filing_taxes: yes_no_or_unfilled(
        yes: benefit_application.primary_member.filing_taxes_next_year_yes?,
        no: benefit_application.primary_member.filing_taxes_next_year_no?,

Avoid comma after the last item of a hash.

Open

      anyone_affected_by_flint_water_crisis: yes_no_or_unfilled(yes_no_for(:flint_water)),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# bad
a = [1, 2,]

# good
a = [
  1, 2,
  3,
]

# good
a = [
  1,
  2,
]

# bad
a = [1, 2,]

# good
a = [
  1,
  2,
]

# bad
a = [1, 2,]

# good
a = [
  1,
  2
]

Avoid comma after the last item of a hash.

Open

        second_filer_filing_jointly: "No",

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# bad
a = [1, 2,]

# good
a = [
  1, 2,
  3,
]

# good
a = [
  1,
  2,
]

# bad
a = [1, 2,]

# good
a = [
  1,
  2,
]

# bad
a = [1, 2,]

# good
a = [
  1,
  2
]