Sign upLogin

codeforamerica/michigan-benefits

View on GitHub
Star

Showing 371 of 372 total issues

Method mb_checkbox_set_with_none has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def mb_checkbox_set_with_none(
    method,
    collection,
    label_text: nil,
    value_is_array: false,
Severity: Minor
Found in app/helpers/mb_form_builder.rb - About 1 hr to fix

    Method execute_callstack_for_multiparameter_attributes has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def execute_callstack_for_multiparameter_attributes(callstack)
    # Disabling Rubcop below because Brakeman is failing to parse the
    #  when we remove the 'begin' keyword
    # rubocop:disable Style/RedundantBegin
    errors = []
    Severity: Minor
    Found in app/models/concerns/multiparameter_attribute_assignment.rb - About 1 hr to fix

      Method supplement_attributes has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def supplement_attributes
    {
      anyone_filing_taxes: yes_no_or_unfilled(
        yes: benefit_application.primary_member.filing_taxes_next_year_yes?,
        no: benefit_application.primary_member.filing_taxes_next_year_no?,
      Severity: Minor
      Found in app/pdf_components/healthcare_coverage_supplement.rb - About 1 hr to fix

        Method employed_attributes has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def employed_attributes
    hash = {
      anyone_employed: yes_no_or_unfilled(
        yes: benefit_application.anyone_employed?,
        no: !benefit_application.anyone_employed?,
        Severity: Minor
        Found in app/pdf_components/assistance_application_form.rb - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            class IntroName < Step
    include MultiparameterAttributeAssignment

    step_attributes(
      :first_name,
          Severity: Major
          Found in app/steps/medicaid/intro_name.rb and 1 other location - About 1 hr to fix
          app/steps/medicaid/intro_household_member.rb on lines 2..28

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            class IntroHouseholdMember < Step
    include MultiparameterAttributeAssignment

    step_attributes(
      :first_name,
          Severity: Major
          Found in app/steps/medicaid/intro_household_member.rb and 1 other location - About 1 hr to fix
          app/steps/medicaid/intro_name.rb on lines 2..28

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method attributes has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def attributes
    [
      {
        "#{position}_member_full_name" => member.display_name,
        "#{position}_member_sex_male" => bool_to_checkbox(member.sex == "male"),
          Severity: Minor
          Found in app/models/snap_application_member_attributes.rb - About 1 hr to fix

            Method add_additional_members_self_employed has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              def add_additional_members_self_employed
    members = benefit_application.members.select(&:self_employed_yes?)
    if members.count > 2
      @_additional_notes[:household_added_notes] = "Yes"
      @_additional_notes[:notes] += "Additional Self-Employed Members:\n"
            Severity: Minor
            Found in app/pdf_components/assistance_application_form.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method employments_valid has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              def employments_valid
    employments.each do |employment|
      employment.errors.clear
      employment.valid?
            Severity: Minor
            Found in app/forms/job_details_form.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              class RemoveAccountController < FormsController
    def update_models
      flash[:notice] = if account && account.destroy
                         "Removed the account."
                       else
            Severity: Minor
            Found in app/controllers/integrated/remove_account_controller.rb and 1 other location - About 50 mins to fix
            app/controllers/integrated/remove_vehicle_controller.rb on lines 2..30

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 43.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              class RemoveVehicleController < FormsController
    def update_models
      flash[:notice] = if vehicle && vehicle.destroy
                         "Removed the vehicle."
                       else
            Severity: Minor
            Found in app/controllers/integrated/remove_vehicle_controller.rb and 1 other location - About 50 mins to fix
            app/controllers/integrated/remove_account_controller.rb on lines 2..30

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 43.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Possible XSS Vulnerability in Action Pack
            Open

                actionpack (5.2.1)
            Severity: Minor
            Found in Gemfile.lock by bundler-audit

            Advisory: CVE-2022-22577

            Criticality: Medium

            URL: https://groups.google.com/g/ruby-security-ann/c/NuFRKaN5swI

            Solution: upgrade to >= 5.2.7.1, ~> 5.2.7, >= 6.0.4.8, ~> 6.0.4, >= 6.1.5.1, ~> 6.1.5, >= 7.0.2.4

            Possible DoS Vulnerability in Active Record PostgreSQL adapter
            Open

                activerecord (5.2.1)
            Severity: Minor
            Found in Gemfile.lock by bundler-audit

            Advisory: CVE-2021-22880

            Criticality: Medium

            URL: https://groups.google.com/g/rubyonrails-security/c/ZzUqCh9vyhI

            Solution: upgrade to >= 5.2.4.5, ~> 5.2.4, >= 6.0.3.5, ~> 6.0.3, >= 6.1.2.1

            Prototype pollution attack through jQuery $.extend
            Open

                jquery-rails (4.3.3)
            Severity: Minor
            Found in Gemfile.lock by bundler-audit

            Advisory: CVE-2019-11358

            Criticality: Medium

            URL: https://blog.jquery.com/2019/04/10/jquery-3-4-0-released/

            Solution: upgrade to >= 4.3.4

            ReDoS based DoS vulnerability in Action Dispatch
            Open

                actionpack (5.2.1)
            Severity: Minor
            Found in Gemfile.lock by bundler-audit

            Advisory: CVE-2023-22792

            URL: https://github.com/rails/rails/releases/tag/v7.0.4.1

            Solution: upgrade to >= 5.2.8.15, ~> 5.2.8, >= 6.1.7.1, ~> 6.1.7, >= 7.0.4.1

            ReDoS based DoS vulnerability in Active Support’s underscore
            Open

                activesupport (5.2.1)
            Severity: Minor
            Found in Gemfile.lock by bundler-audit

            Advisory: CVE-2023-22796

            URL: https://github.com/rails/rails/releases/tag/v7.0.4.1

            Solution: upgrade to >= 5.2.8.15, ~> 5.2.8, >= 6.1.7.1, ~> 6.1.7, >= 7.0.4.1

            HTTP Smuggling via Transfer-Encoding Header in Puma
            Open

                puma (3.12.0)
            Severity: Critical
            Found in Gemfile.lock by bundler-audit

            Advisory: CVE-2020-11076

            Criticality: High

            URL: https://github.com/puma/puma/security/advisories/GHSA-x7jg-6pwg-fx5h

            Solution: upgrade to ~> 3.12.5, >= 4.3.4

            Keepalive thread overload/DoS in puma
            Open

                puma (3.12.0)
            Severity: Critical
            Found in Gemfile.lock by bundler-audit

            Advisory: CVE-2019-16770

            Criticality: High

            URL: https://github.com/puma/puma/security/advisories/GHSA-7xx3-m584-x994

            Solution: upgrade to ~> 3.12.2, >= 4.3.1

            Denial of Service Vulnerability in Rack Content-Disposition parsing
            Open

                rack (2.0.6)
            Severity: Minor
            Found in Gemfile.lock by bundler-audit

            Advisory: CVE-2022-44571

            URL: https://github.com/rack/rack/releases/tag/v3.0.4.1

            Solution: upgrade to >= 2.0.9.2, ~> 2.0.9, >= 2.1.4.2, ~> 2.1.4, >= 2.2.6.1, ~> 2.2.6, >= 3.0.4.1

            Possible Strong Parameters Bypass in ActionPack
            Open

                actionpack (5.2.1)
            Severity: Critical
            Found in Gemfile.lock by bundler-audit

            Advisory: CVE-2020-8164

            Criticality: High

            URL: https://groups.google.com/forum/#!topic/rubyonrails-security/f6ioe4sdpbY

            Solution: upgrade to >= 5.2.4.3, ~> 5.2.4, >= 6.0.3.1

            Severity
            Category
            Status
            Source
            Language