Sign upLogin

codeforamerica/ohana-api

View on GitHub
Star
app/controllers/concerns/private_registration.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

PrivateRegistration#create calls 'resource.errors' 2 times
Open

      email_error = resource.errors[:email]
      resource.errors.delete(:email) if email_error.include?('has already been taken')
Severity: Minor
Found in app/controllers/concerns/private_registration.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

PrivateRegistration#only_email_error_is_duplicate? calls 'resource.errors' 2 times
Open

    resource.errors.keys == [:email] &&
      resource.errors[:email].uniq == ['has already been taken']
Severity: Minor
Found in app/controllers/concerns/private_registration.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Assignment Branch Condition size for create is too high. [<1, 15, 4> 15.56/15]
Open

  def create
    build_resource(sign_up_params)

    if resource.save
      process_successful_registration
Severity: Minor
Found in app/controllers/concerns/private_registration.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric and https://en.wikipedia.org/wiki/ABC_Software_Metric.

You can have repeated "attributes" calls count as a single "branch". For this purpose, attributes are any method with no argument; no attempt is meant to distinguish actual attr_reader from other methods.

Example: CountRepeatedAttributes: false (default is true)

# `model` and `current_user`, refenced 3 times each,
 # are each counted as only 1 branch each if
 # `CountRepeatedAttributes` is set to 'false'

 def search
   @posts = model.active.visible_by(current_user)
             .search(params[:q])
   @posts = model.some_process(@posts, current_user)
   @posts = model.another_process(@posts, current_user)

   render 'pages/search/page'
 end

This cop also takes into account IgnoredMethods (defaults to [])

There are no issues that match your filters.

Category
Status