Sign upLogin

codeforamerica/ohana-api

View on GitHub
Star
app/serializers/locations_serializer.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

LocationsSerializer#coordinates calls 'object.longitude' 2 times
Open

    return [] unless object.longitude.present? && object.latitude.present?

    [object.longitude, object.latitude]
Severity: Minor
Found in app/serializers/locations_serializer.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

LocationsSerializer#coordinates calls 'object.latitude' 2 times
Open

    return [] unless object.longitude.present? && object.latitude.present?

    [object.longitude, object.latitude]
Severity: Minor
Found in app/serializers/locations_serializer.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

There are no issues that match your filters.

Category
Status