codeforamerica/ohana-api

View on GitHub
lib/file_checker.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

FileChecker has at least 16 methods
Open

class FileChecker
Severity: Minor
Found in lib/file_checker.rb by reek

Too Many Methods is a special case of LargeClass.

Example

Given this configuration

TooManyMethods:
  max_methods: 3

and this code:

class TooManyMethods
  def one; end
  def two; end
  def three; end
  def four; end
end

Reek would emit the following warning:

test.rb -- 1 warning:
  [1]:TooManyMethods has at least 4 methods (TooManyMethods)

FileChecker#validate has the variable name 'e'
Open

      header_errors.each { |e| Kernel.puts(e) }
Severity: Minor
Found in lib/file_checker.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

There are no issues that match your filters.

Category
Status