codeforamerica/ohana-api

View on GitHub
lib/location_importer.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

LocationImporter#locations contains iterators nested 2 deep
Open

      chunks.each { |row| locs << LocationPresenter.new(row, addresses).to_location }
Severity: Minor
Found in lib/location_importer.rb by reek

A Nested Iterator occurs when a block contains another block.

Example

Given

class Duck
  class << self
    def duck_names
      %i!tick trick track!.each do |surname|
        %i!duck!.each do |last_name|
          puts "full name is #{surname} #{last_name}"
        end
      end
    end
  end
end

Reek would report the following warning:

test.rb -- 1 warning:
  [5]:Duck#duck_names contains iterators nested 2 deep (NestedIterators)

LocationImporter#import calls 'ENV['sleep']' 2 times
Open

        sleep ENV['sleep'].to_i if ENV['sleep'].present?
Severity: Minor
Found in lib/location_importer.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

LocationImporter#self.process_import has the variable name 'e'
Open

    importer.errors.each { |e| Kernel.puts(e) } unless importer.valid?
Severity: Minor
Found in lib/location_importer.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

There are no issues that match your filters.

Category
Status