Sign upLogin

codeforeurope/tz-geo

View on GitHub
Star

Showing 13 of 13 total issues

Identical blocks of code found in 4 locations. Consider refactoring.
Open

  jstsPolygons.filter(function(jstsPolygon){
    var within = jstsPoint.within(jstsPolygon);
      return within;
    }).forEach(function(poly) {
      // We expect a single result. We should not use an array
Severity: Major
Found in index.js and 3 other locations - About 3 hrs to fix
index.js on lines 24..35
index.js on lines 73..84
index.js on lines 115..126

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

  jstsPolygons.filter(function(jstsPolygon){
    var within = jstsPoint.within(jstsPolygon);
      return within;
    }).forEach(function(poly) {
      // We expect a single result. We should not use an array
Severity: Major
Found in index.js and 3 other locations - About 3 hrs to fix
index.js on lines 24..35
index.js on lines 73..84
index.js on lines 156..167

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

    jstsPolygons.filter(function(jstsPolygon){
    var within = jstsPoint.within(jstsPolygon);
      return within;
    }).forEach(function(poly) {
      // We expect a single result. We should not use an array
Severity: Major
Found in index.js and 3 other locations - About 3 hrs to fix
index.js on lines 24..35
index.js on lines 115..126
index.js on lines 156..167

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

    jstsPolygons.filter(function(jstsPolygon){
    var within = jstsPoint.within(jstsPolygon);
      return within;
    }).forEach(function(poly) {
      // We expect a single result. We should not use an array
Severity: Major
Found in index.js and 3 other locations - About 3 hrs to fix
index.js on lines 73..84
index.js on lines 115..126
index.js on lines 156..167

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

    var jstsPolygons = featurecollection.map(function(feature, index) {
      var geometry = feature.geometry;
      geometry.properties = feature.properties;
      jstsPolygon = geojsonReader.read(geometry);
      jstsPolygon.__index = index;
Severity: Major
Found in index.js and 3 other locations - About 2 hrs to fix
index.js on lines 15..21
index.js on lines 105..111
index.js on lines 146..152

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

  var jstsPolygons = featurecollection.map(function(feature, index) {
    var geometry = feature.geometry;
    geometry.properties = feature.properties;
    jstsPolygon = geojsonReader.read(geometry);
    jstsPolygon.__index = index;
Severity: Major
Found in index.js and 3 other locations - About 2 hrs to fix
index.js on lines 15..21
index.js on lines 64..70
index.js on lines 105..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

    var jstsPolygons = featurecollection.map(function(feature, index) {
      var geometry = feature.geometry;
      geometry.properties = feature.properties;
      jstsPolygon = geojsonReader.read(geometry);
      jstsPolygon.__index = index;
Severity: Major
Found in index.js and 3 other locations - About 2 hrs to fix
index.js on lines 64..70
index.js on lines 105..111
index.js on lines 146..152

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

  var jstsPolygons = featurecollection.map(function(feature, index) {
    var geometry = feature.geometry;
    geometry.properties = feature.properties;
    jstsPolygon = geojsonReader.read(geometry);
    jstsPolygon.__index = index;
Severity: Major
Found in index.js and 3 other locations - About 2 hrs to fix
index.js on lines 15..21
index.js on lines 64..70
index.js on lines 146..152

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function getMoment has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.getMoment = function(point, datetime, callback){
  jstsPoint = geojsonReader.read(point);
  var result;
  var fs = require('fs');
  var path = require('path');
Severity: Minor
Found in index.js - About 1 hr to fix

    Function getTimezone has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.getTimezone = function(point, callback){
  jstsPoint = geojsonReader.read(point);
  var result;
  var fs = require('fs');
  var path = require('path');
    Severity: Minor
    Found in index.js - About 1 hr to fix

      Function tzMoment has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      exports.tzMoment = function(lat,lon, datetime){
  jstsPoint = geojsonReader.read({type: "Point", coordinates: [lon, lat]});
  var result;
  var fs = require('fs');
  var path = require('path');
      Severity: Minor
      Found in index.js - About 1 hr to fix

        Function tz has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        exports.tz = function(lat,lon){
  jstsPoint = geojsonReader.read({type: "Point", coordinates: [lon, lat]});
  var result;
  var fs = require('fs');
  var path = require('path');
        Severity: Minor
        Found in index.js - About 1 hr to fix

          Function tzMoment has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

          exports.tzMoment = function(lat,lon, datetime){
  jstsPoint = geojsonReader.read({type: "Point", coordinates: [lon, lat]});
  var result;
  var fs = require('fs');
  var path = require('path');
          Severity: Minor
          Found in index.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language