protected/RISParser/RISDownloader.php
The method RISDownloader::downloadStrAntragIndex() calls the typical debug function var_dump() which is mostly only used during development. Open
Open
var_dump(curl_getinfo($ch));
- Read upRead up
- Exclude checks
DevelopmentCodeFragment
Since: 2.3.0
Functions like vardump(), printr() etc. are normally only used during development and therefore such calls in production code are a good indicator that they were just forgotten.
Example
class SuspectCode {
public function doSomething(array $items)
{
foreach ($items as $i => $item) {
// …
if ('qafoo' == $item) var_dump($i);
// …
}
}
}
Source https://phpmd.org/rules/design.html#developmentcodefragment
The method downloadSessionCookie() contains an exit expression. Open
Open
die("Could not find a Session ID");
- Read upRead up
- Exclude checks
ExitExpression
Since: 0.2
An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.
Example
class Foo {
public function bar($param) {
if ($param === 42) {
exit(23);
}
}
}
Source https://phpmd.org/rules/design.html#exitexpression
TODO found Open
Open
static::$sessionCookie = '60CA9FDEBAD3573ACF09DD816CBC1711'; // @TODO
- Exclude checks