codeformunich/Muenchen-Transparent

Method parseFromHtml has 34 lines of code (exceeds 30 allowed). Consider refactoring.

Open

    public static function parseFromHtml(string $htmlFraktion, string $htmlAusschuss): ?self
    {
        if (!preg_match('/<h1 class="page-title">\n<span[^>]*>(?<name>[^<]*) <span/siuU', $htmlFraktion, $match)) {
            throw new ParsingException('Not found: name');
        }

The method parseFromHtml() has an NPath complexity of 256. The configured NPath complexity threshold is 200.

Open

    public static function parseFromHtml(string $htmlFraktion, string $htmlAusschuss): ?self
    {
        if (!preg_match('/<h1 class="page-title">\n<span[^>]*>(?<name>[^<]*) <span/siuU', $htmlFraktion, $match)) {
            throw new ParsingException('Not found: name');
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    function bar() {
        // lots of complicated code
    }
}

TODO found

Open

        // @TODO This is only the first page with the most recent memberships

• Exclude checks
  • Disable engine
  • Disable check

Avoid excessively long variable names like $fraktionsMitgliedschaften. Keep variable name length under 20.

Open

    public array $fraktionsMitgliedschaften;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $ausschussMitgliedschaften. Keep variable name length under 20.

Open

    public array $ausschussMitgliedschaften;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}