Sign upLogin

codeformunich/Muenchen-Transparent

View on GitHub
Star
protected/commands/AddressQueryCommand.php

Summary

Maintainability
A
0 mins
Test Coverage

The method AddressQueryCommand::run() calls the typical debug function var_dump() which is mostly only used during development.
Open

        var_dump(ris_intern_address2geo("Deutschland", "", "München", $args[0]));
Severity: Minor
Found in protected/commands/AddressQueryCommand.php by phpmd

DevelopmentCodeFragment

Since: 2.3.0

Functions like vardump(), printr() etc. are normally only used during development and therefore such calls in production code are a good indicator that they were just forgotten.

Example

class SuspectCode {

    public function doSomething(array $items)
    {
        foreach ($items as $i => $item) {
            // …

            if ('qafoo' == $item) var_dump($i);

            // …
        }
    }
}

Source https://phpmd.org/rules/design.html#developmentcodefragment

The method run() contains an exit expression.
Open

        if (count($args) != 1) die("Usage: ./yiic addressquery \"Adresse\"\n");
Severity: Minor
Found in protected/commands/AddressQueryCommand.php by phpmd

ExitExpression

Since: 0.2

An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

Example

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

Source https://phpmd.org/rules/design.html#exitexpression

There are no issues that match your filters.

Category
Status