codeformunich/Muenchen-Transparent

View on GitHub
protected/commands/Benachrichtigungen_DebugCommand.php

Summary

Maintainability
C
7 hrs
Test Coverage

Method run has 44 lines of code (exceeds 30 allowed). Consider refactoring.
Open

    public function run($args)
    {
        if (count($args) != 2) {
            die("./yiic benachrichtigungen_debug [e@mail] [tage]\n");
        }
Severity: Minor
Found in protected/commands/Benachrichtigungen_DebugCommand.php - About 1 hr to fix

    The method run() has an NPath complexity of 200. The configured NPath complexity threshold is 200.
    Open

        public function run($args)
        {
            if (count($args) != 2) {
                die("./yiic benachrichtigungen_debug [e@mail] [tage]\n");
            }

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
        function bar() {
            // lots of complicated code
        }
    }

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method run() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
    Open

        public function run($args)
        {
            if (count($args) != 2) {
                die("./yiic benachrichtigungen_debug [e@mail] [tage]\n");
            }

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
    class Foo {
    1   public function example() {
    2       if ($a == $b) {
    3           if ($a1 == $b1) {
                    fiddle();
    4           } elseif ($a2 == $b2) {
                    fiddle();
                } else {
                    fiddle();
                }
    5       } elseif ($c == $d) {
    6           while ($c == $d) {
                    fiddle();
                }
    7        } elseif ($e == $f) {
    8           for ($n = 0; $n < $h; $n++) {
                    fiddle();
                }
            } else {
                switch ($z) {
    9               case 1:
                        fiddle();
                        break;
    10              case 2:
                        fiddle();
                        break;
    11              case 3:
                        fiddle();
                        break;
                    default:
                        fiddle();
                        break;
                }
            }
        }
    }

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    The method run() contains an exit expression.
    Open

                die("./yiic benachrichtigungen_debug [e@mail] [tage]\n");

    ExitExpression

    Since: 0.2

    An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

    Example

    class Foo {
        public function bar($param)  {
            if ($param === 42) {
                exit(23);
            }
        }
    }

    Source https://phpmd.org/rules/design.html#exitexpression

    The method run() contains an exit expression.
    Open

                die("BenutzerIn nicht gefunden.\n");

    ExitExpression

    Since: 0.2

    An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

    Example

    class Foo {
        public function bar($param)  {
            if ($param === 42) {
                exit(23);
            }
        }
    }

    Source https://phpmd.org/rules/design.html#exitexpression

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if (isset($ergebnisse["antraege"])) foreach ($ergebnisse["antraege"] as $antr) {
                $antrag = $antr["antrag"];
                /** @var Antrag $antrag */
                echo "Antrag: " . $antrag->id . "\n";
                echo "--------\n";
    Severity: Major
    Found in protected/commands/Benachrichtigungen_DebugCommand.php and 1 other location - About 3 hrs to fix
    protected/commands/Benachrichtigungen_DebugCommand.php on lines 42..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 145.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if (isset($ergebnisse["termine"])) foreach ($ergebnisse["termine"] as $antr) {
                $termin = $antr["termin"];
                /** @var Termin $termin */
                echo "Termin: " . $termin->id . "\n";
                echo "--------\n";
    Severity: Major
    Found in protected/commands/Benachrichtigungen_DebugCommand.php and 1 other location - About 3 hrs to fix
    protected/commands/Benachrichtigungen_DebugCommand.php on lines 22..40

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 145.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status