Sign upLogin

codeformunich/Muenchen-Transparent

View on GitHub
Star
protected/commands/Benachrichtigungen_VerschickenCommand.php

Summary

Maintainability
A
1 hr
Test Coverage

The method Benachrichtigungen_VerschickenCommand::run() calls the typical debug function var_dump() which is mostly only used during development.
Open

                var_dump($e);
Severity: Minor
Found in protected/commands/Benachrichtigungen_VerschickenCommand.php by phpmd

DevelopmentCodeFragment

Since: 2.3.0

Functions like vardump(), printr() etc. are normally only used during development and therefore such calls in production code are a good indicator that they were just forgotten.

Example

class SuspectCode {

    public function doSomething(array $items)
    {
        foreach ($items as $i => $item) {
            // …

            if ('qafoo' == $item) var_dump($i);

            // …
        }
    }
}

Source https://phpmd.org/rules/design.html#developmentcodefragment

Avoid unused parameters such as '$data'.
Open

    private function verschickeNeueBenachrichtigungen_txt(BenutzerIn $benutzerIn, array $data): string
Severity: Minor
Found in protected/commands/Benachrichtigungen_VerschickenCommand.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

The method run() contains an exit expression.
Open

            if (!$benutzerIn) die("BenutzerIn nicht gefunden.\n");
Severity: Minor
Found in protected/commands/Benachrichtigungen_VerschickenCommand.php by phpmd

ExitExpression

Since: 0.2

An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

Example

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

Source https://phpmd.org/rules/design.html#exitexpression

The method run() contains an exit expression.
Open

        if (count($args) == 1) die("./yiic benachrichtigungen_verschicken [e@mail tage]\n");
Severity: Minor
Found in protected/commands/Benachrichtigungen_VerschickenCommand.php by phpmd

ExitExpression

Since: 0.2

An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

Example

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

Source https://phpmd.org/rules/design.html#exitexpression

Avoid unused parameters such as '$data'.
Open

    private function verschickeNeueBenachrichtigungen_html(BenutzerIn $benutzerIn, array $data): string
Severity: Minor
Found in protected/commands/Benachrichtigungen_VerschickenCommand.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$benutzerIn'.
Open

    private function verschickeNeueBenachrichtigungen_txt(BenutzerIn $benutzerIn, array $data): string
Severity: Minor
Found in protected/commands/Benachrichtigungen_VerschickenCommand.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$benutzerIn'.
Open

    private function verschickeNeueBenachrichtigungen_html(BenutzerIn $benutzerIn, array $data): string
Severity: Minor
Found in protected/commands/Benachrichtigungen_VerschickenCommand.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private function verschickeNeueBenachrichtigungen_html(BenutzerIn $benutzerIn, array $data): string
    {
        $path = Yii::getPathOfAlias('application.views.benachrichtigungen') . '/suchergebnisse_email_html.php';
        if (!file_exists($path)) throw new Exception('Template ' . $path . ' does not exist.');
        ob_start();
Severity: Minor
Found in protected/commands/Benachrichtigungen_VerschickenCommand.php and 1 other location - About 50 mins to fix
protected/commands/Benachrichtigungen_VerschickenCommand.php on lines 5..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 97.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private function verschickeNeueBenachrichtigungen_txt(BenutzerIn $benutzerIn, array $data): string
    {
        $path = Yii::getPathOfAlias('application.views.benachrichtigungen') . '/suchergebnisse_email_txt.php';
        if (!file_exists($path)) throw new Exception('Template ' . $path . ' does not exist.');
        ob_start();
Severity: Minor
Found in protected/commands/Benachrichtigungen_VerschickenCommand.php and 1 other location - About 50 mins to fix
protected/commands/Benachrichtigungen_VerschickenCommand.php on lines 16..24

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 97.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status