Sign upLogin

codeformunich/Muenchen-Transparent

View on GitHub
Star
protected/controllers/AdminController.php

Summary

Maintainability
A
2 hrs
Test Coverage

The method AdminController::actionBuergerInnenversammlungen() calls the typical debug function print_r() which is mostly only used during development.
Open

                    $this->msg_err = print_r($termin->getErrors(), true);
Severity: Minor
Found in protected/controllers/AdminController.php by phpmd

DevelopmentCodeFragment

Since: 2.3.0

Functions like vardump(), printr() etc. are normally only used during development and therefore such calls in production code are a good indicator that they were just forgotten.

Example

class SuspectCode {

    public function doSomething(array $items)
    {
        foreach ($items as $i => $item) {
            // …

            if ('qafoo' == $item) var_dump($i);

            // …
        }
    }
}

Source https://phpmd.org/rules/design.html#developmentcodefragment

The class AdminController has an overall complexity of 51 which is very high. The configured complexity threshold is 50.
Open

class AdminController extends RISBaseController
{
    public function actionStadtraetInnenPersonen()
    {
        if (!$this->binContentAdmin()) $this->errorMessageAndDie(403, "");
Severity: Minor
Found in protected/controllers/AdminController.php by phpmd

Method actionTags has 48 lines of code (exceeds 30 allowed). Consider refactoring.
Open

    public function actionTags()
    {
        $ich = $this->aktuelleBenutzerIn();
        if (!$ich || !$ich->hatBerechtigung(BenutzerIn::BERECHTIGUNG_TAG)) $this->errorMessageAndDie(403, "");
Severity: Minor
Found in protected/controllers/AdminController.php - About 1 hr to fix

    Method actionBuergerInnenversammlungen has 36 lines of code (exceeds 30 allowed). Consider refactoring.
    Open

        public function actionBuergerInnenversammlungen()
    {
        if (!$this->binContentAdmin()) $this->errorMessageAndDie(403, "");

        $this->top_menu = "admin";
    Severity: Minor
    Found in protected/controllers/AdminController.php - About 1 hr to fix

      The method actionBuergerInnenversammlungen() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
      Open

          public function actionBuergerInnenversammlungen()
    {
        if (!$this->binContentAdmin()) $this->errorMessageAndDie(403, "");

        $this->top_menu = "admin";
      Severity: Minor
      Found in protected/controllers/AdminController.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      There are no issues that match your filters.

      Category
      Status