Sign upLogin

codeformunich/Muenchen-Transparent

View on GitHub
Star
protected/controllers/ExportController.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method actionFraktionantraege has 65 lines of code (exceeds 30 allowed). Consider refactoring.
Open

    public function actionFraktionantraege($fraktion_id, $limit = 30, $offset = 0) {
        Header("Content-Type: application/json; charset=UTF-8");

        /** @var Fraktion $fraktion */
        $fraktion = Fraktion::model()->findByPk( $fraktion_id );
Severity: Major
Found in protected/controllers/ExportController.php - About 2 hrs to fix

    The method actionFraktionantraege() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
    Open

        public function actionFraktionantraege($fraktion_id, $limit = 30, $offset = 0) {
        Header("Content-Type: application/json; charset=UTF-8");

        /** @var Fraktion $fraktion */
        $fraktion = Fraktion::model()->findByPk( $fraktion_id );
    Severity: Minor
    Found in protected/controllers/ExportController.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    There are no issues that match your filters.

    Category
    Status