Sign upLogin

codeformunich/Muenchen-Transparent

View on GitHub
Star
protected/controllers/InfosController.php

Summary

Maintainability
A
0 mins
Test Coverage

The method InfosController::actionFeedback() calls the typical debug function print_r() which is mostly only used during development.
Open

            fwrite($fp, print_r($_REQUEST, true));
Severity: Minor
Found in protected/controllers/InfosController.php by phpmd

DevelopmentCodeFragment

Since: 2.3.0

Functions like vardump(), printr() etc. are normally only used during development and therefore such calls in production code are a good indicator that they were just forgotten.

Example

class SuspectCode {

    public function doSomething(array $items)
    {
        foreach ($items as $i => $item) {
            // …

            if ('qafoo' == $item) var_dump($i);

            // …
        }
    }
}

Source https://phpmd.org/rules/design.html#developmentcodefragment

The class InfosController has 12 public methods. Consider refactoring InfosController to keep number of public methods under 10.
Open

class InfosController extends RISBaseController
{
    public function actionSoFunktioniertStadtpolitik()
    {
        $this->top_menu = "so_funktioniert";
Severity: Minor
Found in protected/controllers/InfosController.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

The method std_content_page() contains an exit expression.
Open

            if (strlen($_REQUEST["text"]) == 0) die("Kein Text angegeben");
Severity: Minor
Found in protected/controllers/InfosController.php by phpmd

ExitExpression

Since: 0.2

An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

Example

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

Source https://phpmd.org/rules/design.html#exitexpression

The method actionSoFunktioniertStadtpolitik() contains an exit expression.
Open

            if (strlen($_REQUEST["text"]) == 0) die("Kein Text angegeben");
Severity: Minor
Found in protected/controllers/InfosController.php by phpmd

ExitExpression

Since: 0.2

An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

Example

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

Source https://phpmd.org/rules/design.html#exitexpression

There are no issues that match your filters.

Category
Status