Sign upLogin

codeformunich/Muenchen-Transparent

View on GitHub
Star
protected/models/Tagesordnungspunkt.php

Summary

Maintainability
A
55 mins
Test Coverage

The method Tagesordnungspunkt::copyToHistory() calls the typical debug function print_r() which is mostly only used during development.
Open

                RISTools::report_ris_parser_error("TagesordnungspunktHistory:moveToHistory Error", print_r($history->getErrors(), true));
Severity: Minor
Found in protected/models/Tagesordnungspunkt.php by phpmd

DevelopmentCodeFragment

Since: 2.3.0

Functions like vardump(), printr() etc. are normally only used during development and therefore such calls in production code are a good indicator that they were just forgotten.

Example

class SuspectCode {

    public function doSomething(array $items)
    {
        foreach ($items as $i => $item) {
            // …

            if ('qafoo' == $item) var_dump($i);

            // …
        }
    }
}

Source https://phpmd.org/rules/design.html#developmentcodefragment

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    public function relations()
    {
        // NOTE: you may need to adjust the relation name and the related
        // class name for the relations automatically generated below.
        return [
Severity: Major
Found in protected/models/Tagesordnungspunkt.php and 3 other locations - About 55 mins to fix
protected/models/AntragOrt.php on lines 62..73
protected/models/TagesordnungspunktHistory.php on lines 66..77
protected/models/Termin.php on lines 81..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status