Sign upLogin

codekitchen/tkellem

View on GitHub
Star
lib/tkellem/bouncer.rb

Summary

Maintainability
C
1 day
Test Coverage

Method server_msg has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

  def server_msg(msg)
    return if plugins.any? do |plugin|
      !plugin.server_msg(self, msg)
    end
Severity: Minor
Found in lib/tkellem/bouncer.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method server_msg has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def server_msg(msg)
    return if plugins.any? do |plugin|
      !plugin.server_msg(self, msg)
    end
Severity: Major
Found in lib/tkellem/bouncer.rb - About 2 hrs to fix

    Method client_msg has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

      def client_msg(client, msg)
    return if plugins.any? do |plugin|
      !plugin.client_msg(self, client, msg)
    end
    Severity: Minor
    Found in lib/tkellem/bouncer.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method client_msg has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def client_msg(client, msg)
    return if plugins.any? do |plugin|
      !plugin.client_msg(self, client, msg)
    end
    Severity: Minor
    Found in lib/tkellem/bouncer.rb - About 1 hr to fix

      Method check_away_status has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def check_away_status
    # for now we pretty much randomly pick an away status if multiple are set
    # by clients
    if @away.any? { |k,v| !v }
      # we have a client who isn't away
      Severity: Minor
      Found in lib/tkellem/bouncer.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status