Showing 408 of 408 total issues
Function displayMenu has 95 lines of code (exceeds 25 allowed). Consider refactoring. Open
myOwn.displayMenu = function displayMenu(layout, menu, addrParams, parents){
var my = this;
var selectedItem = null;
var elements=[];
var depth = parents.length;Function prepareMenu has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring. Open
myOwn.TableGrid.prototype.prepareMenu = function prepareMenu(button){
button.src=my.path.img+'menu-dots.png';
button.title=my.messages.optionsForThisTable;
var grid=this;
var menuOptions=[];- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function controlar_compatibilidad has 93 lines of code (exceeds 25 allowed). Consider refactoring. Open
function controlar_compatibilidad(ya, id, idBoton){
"use strict";
var boton=document.getElementById(idBoton || 'login');
id = id || 'resultado_incompatibilidad';
var div=document.getElementById(id);Function showParams has 92 lines of code (exceeds 25 allowed). Consider refactoring. Open
showParams:function(formDef, main_layout, addrParams, mainAction){
var autoproced = addrParams.autoproced || false
addrParams.up=addrParams.up||addrParams.ff||{};
var params=addrParams.up;
// var button = html.button(formDef.proceedLabel||my.messages.proceed).create();Similar blocks of code found in 2 locations. Consider refactoring. Open
myOwn.TableConnector.prototype.recordEnter = function recordEnter(depot){
return (!this.my.config.cursor || depot.primaryKeyValues===false?
Promise.resolve():
depot.my.ajax.table_record_enter({
table:depot.def.name, - Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 108.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
myOwn.TableConnector.prototype.recordLeave = function recordLeave(depot){
return (!this.my.config.cursor || depot.primaryKeyValues===false?
Promise.resolve():
depot.my.ajax.table_record_leave({
table:depot.def.name, - Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 108.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function doneFun has 90 lines of code (exceeds 25 allowed). Consider refactoring. Open
var doneFun = function doneFun(){
var fileAttr={class:'import-button',type:'file',style:'min-width:400px'};
if(acceptPhotos){
fileAttr.accept='image/*';
}Function exportacionesGenerico has 90 lines of code (exceeds 25 allowed). Consider refactoring. Open
AppBackend.prototype.exportacionesGenerico = async function exportacionesGenerico(result, procedureDef, context, params, files){
var {csvFileName, fileName} = procedureDef.forExport
if (!(result instanceof Array)) {
if (!result || !(result instanceof Object)) {
throw new Error ("exportacionesGenerico debe recibir {title:string, rows:Record<string, any>[]}[]")Function dialogInput has 89 lines of code (exceeds 25 allowed). Consider refactoring. Open
dialogInput:function(typedControl, opts){
opts = changing({
reference: {},
extraRow: null
},opts ||{});Function readProcedureDefinitions has 89 lines of code (exceeds 25 allowed). Consider refactoring. Open
myAjax.readProcedureDefinitions=function readProcedureDefinitions(){
var my = this;
var promise;
var getStored=function(setupOrError){
if(setupOrError && !(setupOrError instanceof Error) && !setupOrError.isoffline){Function refreshAllRows has 89 lines of code (exceeds 25 allowed). Consider refactoring. Open
grid.refreshAllRows = async function(force){
var timeStamp = new Date().getTime();
await grid.connector.my.ajax.table_data({
table:grid.connector.tableName,
fixedFields:grid.connector.fixedFields,Function defaultInformProgress has 88 lines of code (exceeds 25 allowed). Consider refactoring. Open
var defaultInformProgress = function defaultInformProgress(progressInfo){
if(progressInfo.message || progressInfo.end || progressInfo.start || progressInfo.loaded){
// progressInfo.idGroup
if(!divProgress){
var idAutoClose='id-auto-close-'+Math.random();Function tipoCeldas has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring. Open
tipoCeldas(){
//var tiposCeldas = {
return {
titulo:{
completar: function completar(){- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function informDetectedStatus has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring. Open
myOwn.informDetectedStatus = function informDetectedStatus(statusCode, logged) {
var my=this;
if(my.debuggingStatus){ my.debuggingStatus(statusCode); }
if(my.previousStatusCode!=statusCode){
// var previousStatus = my["connection-status"][my.previousStatusCode];- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function showPage has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring. Open
myOwn.showPage = function showPage(pageDef){
my.prepareFloating3dots();
var newHash;
if(!location.hash){
newHash=sessionStorage.getItem('backend-plus-hash-redirect');- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 2 locations. Consider refactoring. Open
myOwn.i18n.messages.en=changing(myOwn.i18n.messages.en, {
chpass:'change password',
completed:'completed',
exit:'exit',
networkSignal1:'network $1',- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 102.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if(
'maxCount' in procedureDef.files && files.length<procedureDef.files.maxCount &&
'count' in procedureDef.files && files.length<procedureDef.files.count
){
throw new Error("internal procedure "+procedureDef.action+" error: receiving less than "+procedureDef.files.minCount+" files");- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 102.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
myOwn.i18n.messages.es=changing(myOwn.i18n.messages.es, {
chpass:'cambiar clave',
completed:'finalizado',
exit:'salir',
networkSignal1:'estado de la red: $1',- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 102.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if(
'minCount' in procedureDef.files && files.length<procedureDef.files.minCount &&
'count' in procedureDef.files && files.length<procedureDef.files.count
){
throw new Error("internal procedure "+procedureDef.action+" error: receiving less than "+procedureDef.files.minCount+" files");- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 102.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function td has 83 lines of code (exceeds 25 allowed). Consider refactoring. Open
myOwn.DataColumnGrid.prototype.td = function td(depot, iColumn, tr, saveRow){
var grid = this.grid;
var fieldDef = this.fieldDef;
var forInsert = false; // TODO: Verificar que esto está en desuso
var enabledInput=depot.allow.update !== false && grid.def.allow.update /* && !grid.connector.fixedField[fieldDef.name] */ && (forInsert?fieldDef.allow.insert:fieldDef.allow.update);