codenautas/backend-plus

View on GitHub
src/for-client/my-localdb.ts

Summary

Maintainability
F
4 days
Test Coverage

File my-localdb.ts has 394 lines of code (exceeds 250 allowed). Consider refactoring.
Open

//import { TableDefinition } from "backend-plus";
"use strict";
//x// <amd-dependency path="../../../node_modules/like-ar/like-ar.d.ts" name="likeAr"/>
//x// <reference path="../../node_modules/like-ar/like-ar.d.ts" />
/// <reference path="../node_modules/types.d.ts/modules/myOwn/in-myOwn.d.ts" />
Severity: Minor
Found in src/for-client/my-localdb.ts - About 5 hrs to fix

    Function putOneAndGetIfNeeded has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private async putOneAndGetIfNeeded<T extends Record>(tableName:string, element:T, needed:boolean):Promise<T|void>{
            var ldb=this;
            var db=await ldb.wait4db
            var tableDef=await ldb.getStructure(tableName);
            var createPromiseForFK = function createPromiseForFK(fk:ForeignKey){
    Severity: Major
    Found in src/for-client/my-localdb.ts - About 2 hrs to fix

      Function putOneAndGetIfNeeded has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          private async putOneAndGetIfNeeded<T extends Record>(tableName:string, element:T, needed:boolean):Promise<T|void>{
              var ldb=this;
              var db=await ldb.wait4db
              var tableDef=await ldb.getStructure(tableName);
              var createPromiseForFK = function createPromiseForFK(fk:ForeignKey){
      Severity: Minor
      Found in src/for-client/my-localdb.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function inTransaction has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          async inTransaction<T>(callback:(ldb:LocalDb)=>Promise<T>):Promise<T>{
              var name=this.localDbName;
              this.oneByOneChain = this.oneByOneChain.then(async function(){
                  var ldb = new LocalDb(name);
                  async function closeLdb(err:Error):Promise<never>;
      Severity: Minor
      Found in src/for-client/my-localdb.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function registerStructureInside has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private async registerStructureInside(tableDef:TableDefinition, wait4db:Promise<IDBDatabase>):Promise<{
              wait4db:Promise<IDBDatabase>,
              result:RegisterResult
          }>{
              var ldb=this;
      Severity: Minor
      Found in src/for-client/my-localdb.ts - About 1 hr to fix

        Function getChild has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            async getChild<T>(tableName:string, parentKey:Key):Promise<T[]>{
                var ldb=this;
                var db=await ldb.wait4db
                var rows:T[]=[];
                var internalKey:string|Key;
        Severity: Minor
        Found in src/for-client/my-localdb.ts - About 1 hr to fix

          Function registerStructureInside has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              private async registerStructureInside(tableDef:TableDefinition, wait4db:Promise<IDBDatabase>):Promise<{
                  wait4db:Promise<IDBDatabase>,
                  result:RegisterResult
              }>{
                  var ldb=this;
          Severity: Minor
          Found in src/for-client/my-localdb.ts - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function constructor has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              constructor(public name:string){
                  var ldb=this;
                  var initialStores:StoreDefs={
                      $structures:'name',
                      $internals:'var',
          Severity: Minor
          Found in src/for-client/my-localdb.ts - About 1 hr to fix

            Function inTransaction has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                async inTransaction<T>(callback:(ldb:LocalDb)=>Promise<T>):Promise<T>{
                    var name=this.localDbName;
                    this.oneByOneChain = this.oneByOneChain.then(async function(){
                        var ldb = new LocalDb(name);
                        async function closeLdb(err:Error):Promise<never>;
            Severity: Minor
            Found in src/for-client/my-localdb.ts - About 1 hr to fix

              Function detectFeatures has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  async detectFeatures(store:IDBObjectStore):Promise<DetectFeatures>{
                      return new Promise<DetectFeatures>((resolve) => {
                          try{
                              // @ts-ignore
                              var os: string = window.myOwn.config.useragent.os;
              Severity: Minor
              Found in src/for-client/my-localdb.ts - About 1 hr to fix

                Function putMany has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    async putMany<T>(tableName:string, elements:T[]):Promise<void>{
                        var ldb=this;
                        var db=await ldb.wait4db
                        var tableDef=await ldb.getStructure(tableName);
                        
                Severity: Minor
                Found in src/for-client/my-localdb.ts - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        var createPromiseForFK = function createPromiseForFK(fk:ForeignKey){
                            return Promise.resolve().then(async function(){
                                var fkTableDef=await ldb.getStructure(fk.references);
                                if(fkTableDef){
                                    var pk:string[] = [];
                Severity: Major
                Found in src/for-client/my-localdb.ts and 1 other location - About 1 day to fix
                src/for-client/my-websqldb.ts on lines 272..293

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 300.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        if(!ldb.wait4detectedFeatures){
                            ldb.wait4detectedFeatures = ldb.detectFeatures(db.transaction('$detect',"readwrite").objectStore('$detect'));
                        }
                Severity: Minor
                Found in src/for-client/my-localdb.ts and 1 other location - About 40 mins to fix
                src/for-client/my-localdb.ts on lines 187..189

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 49.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    async existsStructure(tableName:string):Promise<boolean>{
                        var tableDef = await this.getStructure(tableName);
                        return tableDef?true:false;
                    }
                Severity: Minor
                Found in src/for-client/my-localdb.ts and 1 other location - About 40 mins to fix
                src/for-client/my-websqldb.ts on lines 164..167

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 49.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        if(!ldb.wait4detectedFeatures){
                            ldb.wait4detectedFeatures = ldb.detectFeatures(db.transaction('$detect',"readwrite").objectStore('$detect'));
                        }
                Severity: Minor
                Found in src/for-client/my-localdb.ts and 1 other location - About 40 mins to fix
                src/for-client/my-localdb.ts on lines 218..220

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 49.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                        if(tableDef.foreignKeys){
                            tableDef.foreignKeys.forEach(async function(fk){
                                promisesArray.push(createPromiseForFK(fk));
                            });
                        }
                Severity: Major
                Found in src/for-client/my-localdb.ts and 3 other locations - About 35 mins to fix
                src/for-client/my-localdb.ts on lines 333..337
                src/for-client/my-websqldb.ts on lines 297..301
                src/for-client/my-websqldb.ts on lines 302..306

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 47.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                        if(tableDef.softForeignKeys){
                            tableDef.softForeignKeys.forEach(async function(fk){
                                promisesArray.push(createPromiseForFK(fk));
                            });
                        }
                Severity: Major
                Found in src/for-client/my-localdb.ts and 3 other locations - About 35 mins to fix
                src/for-client/my-localdb.ts on lines 328..332
                src/for-client/my-websqldb.ts on lines 297..301
                src/for-client/my-websqldb.ts on lines 302..306

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 47.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status