codenautas/best-globals

View on GitHub

Showing 37 of 37 total issues

Function ymdHms has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

bestGlobals.datetime.ymdHms = function ymdHms(y, m, d, hh, mm, ss) {
Severity: Minor
Found in best-globals.js - About 45 mins to fix

    Consider simplifying this complex logical expression.
    Open

        if(match){
            var integerParts={};
            integerParts.year    = parseInt(match[2],10)
            integerParts.month   = parseInt(match[4],10)
            integerParts.day     = parseInt(match[7],10)
    Severity: Major
    Found in best-globals.js - About 40 mins to fix

      Consider simplifying this complex logical expression.
      Open

          if(original===null ||
              !bestGlobals.isPlainObject(original) &&
                  !(original instanceof Error) &&
                  (!opts.mostlyPlain || typeof original != "object" || !bestGlobals.isPlainObject(changes))
               // && !bestGlobals.changing
      Severity: Major
      Found in best-globals.js - About 40 mins to fix

        Consider simplifying this complex logical expression.
        Open

            if(m){
                var sign=m[1]=='-'?-1:1;
                return bestGlobals.timeInterval({
                    ms     : m[8]*sign||0,
                    seconds: m[7]*sign||0,
        Severity: Major
        Found in best-globals.js - About 40 mins to fix

          Function isValidTime has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          bestGlobals.Datetime.isValidTime = function isValidTime(h, m, s, ms, micros) {
          Severity: Minor
          Found in best-globals.js - About 35 mins to fix

            Function toHms has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                this.toHms = function toHms(omitSeconds, withDays, omitLeftCeros, omitHourCero, omitFirstLeftCero) {
            Severity: Minor
            Found in best-globals.js - About 35 mins to fix

              Function codenautasModuleDefinition has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              (function codenautasModuleDefinition(root, name, factory) {
                  /* global define */
                  /* istanbul ignore next */
                  if(typeof root.globalModuleName !== 'string'){
                      root.globalModuleName = name;
              Severity: Minor
              Found in best-globals.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this function.
              Open

                      return 0;
              Severity: Major
              Found in best-globals.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            if(!(name in b) || !bestGlobals.sameValue(a[name],b[name])) return false;
                Severity: Major
                Found in best-globals.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return bestGlobals.sameValues(a,b,"right") && bestGlobals.sameValues(a,b,"left");
                  Severity: Major
                  Found in best-globals.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return true;
                    Severity: Major
                    Found in best-globals.js - About 30 mins to fix

                      Unexpected require().
                      Open

                          var karma = require('karma');
                      Severity: Minor
                      Found in server-for-test/karma-server.js by eslint

                      Enforce require() on the top-level module scope (global-require)

                      In Node.js, module dependencies are included using the require() function, such as:

                      var fs = require("fs");

                      While require() may be called anywhere in code, some style guides prescribe that it should be called only in the top level of a module to make it easier to identify dependencies. For instance, it's arguably harder to identify dependencies when they are deeply nested inside of functions and other statements:

                      function foo() {
                      
                          if (condition) {
                              var fs = require("fs");
                          }
                      }

                      Since require() does a synchronous load, it can cause performance problems when used in other locations.

                      Further, ES6 modules mandate that import and export statements can only occur in the top level of the module's body.

                      Rule Details

                      This rule requires all calls to require() to be at the top level of the module, similar to ES6 import and export statements, which also can occur only at the top level.

                      Examples of incorrect code for this rule:

                      /*eslint global-require: "error"*/
                      /*eslint-env es6*/
                      
                      // calling require() inside of a function is not allowed
                      function readFile(filename, callback) {
                          var fs = require('fs');
                          fs.readFile(filename, callback)
                      }
                      
                      // conditional requires like this are also not allowed
                      if (DEBUG) { require('debug'); }
                      
                      // a require() in a switch statement is also flagged
                      switch(x) { case '1': require('1'); break; }
                      
                      // you may not require() inside an arrow function body
                      var getModule = (name) => require(name);
                      
                      // you may not require() inside of a function body as well
                      function getModule(name) { return require(name); }
                      
                      // you may not require() inside of a try/catch block
                      try {
                          require(unsafeModule);
                      } catch(e) {
                          console.log(e);
                      }

                      Examples of correct code for this rule:

                      /*eslint global-require: "error"*/
                      
                      // all these variations of require() are ok
                      require('x');
                      var y = require('y');
                      var z;
                      z = require('z').initialize();
                      
                      // requiring a module and using it in a function is ok
                      var fs = require('fs');
                      function readFile(filename, callback) {
                          fs.readFile(filename, callback)
                      }
                      
                      // you can use a ternary to determine which module to require
                      var logger = DEBUG ? require('dev-logger') : require('logger');
                      
                      // if you want you can require() at the end of your module
                      function doSomethingA() {}
                      function doSomethingB() {}
                      var x = require("x"),
                          z = require("z");

                      When Not To Use It

                      If you have a module that must be initialized with information that comes from the file-system or if a module is only used in very rare situations and will cause significant overhead to load it may make sense to disable the rule. If you need to require() an optional dependency inside of a try/catch, you can disable this rule for just that dependency using the // eslint-disable-line global-require comment. Source: http://eslint.org/docs/rules/

                      Unexpected require().
                      Open

                          var karmaConfig = require('../karma.conf.js');
                      Severity: Minor
                      Found in server-for-test/karma-server.js by eslint

                      Enforce require() on the top-level module scope (global-require)

                      In Node.js, module dependencies are included using the require() function, such as:

                      var fs = require("fs");

                      While require() may be called anywhere in code, some style guides prescribe that it should be called only in the top level of a module to make it easier to identify dependencies. For instance, it's arguably harder to identify dependencies when they are deeply nested inside of functions and other statements:

                      function foo() {
                      
                          if (condition) {
                              var fs = require("fs");
                          }
                      }

                      Since require() does a synchronous load, it can cause performance problems when used in other locations.

                      Further, ES6 modules mandate that import and export statements can only occur in the top level of the module's body.

                      Rule Details

                      This rule requires all calls to require() to be at the top level of the module, similar to ES6 import and export statements, which also can occur only at the top level.

                      Examples of incorrect code for this rule:

                      /*eslint global-require: "error"*/
                      /*eslint-env es6*/
                      
                      // calling require() inside of a function is not allowed
                      function readFile(filename, callback) {
                          var fs = require('fs');
                          fs.readFile(filename, callback)
                      }
                      
                      // conditional requires like this are also not allowed
                      if (DEBUG) { require('debug'); }
                      
                      // a require() in a switch statement is also flagged
                      switch(x) { case '1': require('1'); break; }
                      
                      // you may not require() inside an arrow function body
                      var getModule = (name) => require(name);
                      
                      // you may not require() inside of a function body as well
                      function getModule(name) { return require(name); }
                      
                      // you may not require() inside of a try/catch block
                      try {
                          require(unsafeModule);
                      } catch(e) {
                          console.log(e);
                      }

                      Examples of correct code for this rule:

                      /*eslint global-require: "error"*/
                      
                      // all these variations of require() are ok
                      require('x');
                      var y = require('y');
                      var z;
                      z = require('z').initialize();
                      
                      // requiring a module and using it in a function is ok
                      var fs = require('fs');
                      function readFile(filename, callback) {
                          fs.readFile(filename, callback)
                      }
                      
                      // you can use a ternary to determine which module to require
                      var logger = DEBUG ? require('dev-logger') : require('logger');
                      
                      // if you want you can require() at the end of your module
                      function doSomethingA() {}
                      function doSomethingB() {}
                      var x = require("x"),
                          z = require("z");

                      When Not To Use It

                      If you have a module that must be initialized with information that comes from the file-system or if a module is only used in very rare situations and will cause significant overhead to load it may make sense to disable the rule. If you need to require() an optional dependency inside of a try/catch, you can disable this rule for just that dependency using the // eslint-disable-line global-require comment. Source: http://eslint.org/docs/rules/

                      Wrap an immediate function invocation in parentheses.
                      Open

                                  last = 'to' in NorFirstOrObject ? NorFirstOrObject.to : function (){ throw new Error('serie lack of "from" or "to"') }();
                      Severity: Minor
                      Found in best-globals.js by eslint

                      Require IIFEs to be Wrapped (wrap-iife)

                      You can immediately invoke function expressions, but not function declarations. A common technique to create an immediately-invoked function expression (IIFE) is to wrap a function declaration in parentheses. The opening parentheses causes the contained function to be parsed as an expression, rather than a declaration.

                      // function expression could be unwrapped
                      var x = function () { return { y: 1 };}();
                      
                      // function declaration must be wrapped
                      function () { /* side effects */ }(); // SyntaxError

                      Rule Details

                      This rule requires all immediately-invoked function expressions to be wrapped in parentheses.

                      Options

                      This rule has two options, a string option and an object option.

                      String option:

                      • "outside" enforces always wrapping the call expression. The default is "outside".
                      • "inside" enforces always wrapping the function expression.
                      • "any" enforces always wrapping, but allows either style.

                      Object option:

                      • "functionPrototypeMethods": true additionally enforces wrapping function expressions invoked using .call and .apply. The default is false.

                      outside

                      Examples of incorrect code for the default "outside" option:

                      /*eslint wrap-iife: ["error", "outside"]*/
                      
                      var x = function () { return { y: 1 };}(); // unwrapped
                      var x = (function () { return { y: 1 };})(); // wrapped function expression

                      Examples of correct code for the default "outside" option:

                      /*eslint wrap-iife: ["error", "outside"]*/
                      
                      var x = (function () { return { y: 1 };}()); // wrapped call expression

                      inside

                      Examples of incorrect code for the "inside" option:

                      /*eslint wrap-iife: ["error", "inside"]*/
                      
                      var x = function () { return { y: 1 };}(); // unwrapped
                      var x = (function () { return { y: 1 };}()); // wrapped call expression

                      Examples of correct code for the "inside" option:

                      /*eslint wrap-iife: ["error", "inside"]*/
                      
                      var x = (function () { return { y: 1 };})(); // wrapped function expression

                      any

                      Examples of incorrect code for the "any" option:

                      /*eslint wrap-iife: ["error", "any"]*/
                      
                      var x = function () { return { y: 1 };}(); // unwrapped

                      Examples of correct code for the "any" option:

                      /*eslint wrap-iife: ["error", "any"]*/
                      
                      var x = (function () { return { y: 1 };}()); // wrapped call expression
                      var x = (function () { return { y: 1 };})(); // wrapped function expression

                      functionPrototypeMethods

                      Examples of incorrect code for this rule with the "inside", { "functionPrototypeMethods": true } options:

                      /* eslint wrap-iife: [2, "inside", { functionPrototypeMethods: true }] */
                      
                      var x = function(){ foo(); }()
                      var x = (function(){ foo(); }())
                      var x = function(){ foo(); }.call(bar)
                      var x = (function(){ foo(); }.call(bar))

                      Examples of correct code for this rule with the "inside", { "functionPrototypeMethods": true } options:

                      /* eslint wrap-iife: [2, "inside", { functionPrototypeMethods: true }] */
                      
                      var x = (function(){ foo(); })()
                      var x = (function(){ foo(); }).call(bar)

                      Source: http://eslint.org/docs/rules/

                      'karma' is already defined.
                      Open

                          var karma = require('karma');
                      Severity: Minor
                      Found in server-for-test/karma-server.js by eslint

                      disallow variable redeclaration (no-redeclare)

                      In JavaScript, it's possible to redeclare the same variable name using var. This can lead to confusion as to where the variable is actually declared and initialized.

                      Rule Details

                      This rule is aimed at eliminating variables that have multiple declarations in the same scope.

                      Examples of incorrect code for this rule:

                      /*eslint no-redeclare: "error"*/
                      
                      var a = 3;
                      var a = 10;

                      Examples of correct code for this rule:

                      /*eslint no-redeclare: "error"*/
                      
                      var a = 3;
                      // ...
                      a = 10;

                      Options

                      This rule takes one optional argument, an object with a boolean property "builtinGlobals". It defaults to false. If set to true, this rule also checks redeclaration of built-in globals, such as Object, Array, Number...

                      builtinGlobals

                      Examples of incorrect code for the { "builtinGlobals": true } option:

                      /*eslint no-redeclare: ["error", { "builtinGlobals": true }]*/
                      
                      var Object = 0;

                      Examples of incorrect code for the { "builtinGlobals": true } option and the browser environment:

                      /*eslint no-redeclare: ["error", { "builtinGlobals": true }]*/
                      /*eslint-env browser*/
                      
                      var top = 0;

                      The browser environment has many built-in global variables (for example, top). Some of built-in global variables cannot be redeclared. Source: http://eslint.org/docs/rules/

                      Don't use process.exit(); throw an error instead.
                      Open

                              process.exit(exitCode);
                      Severity: Minor
                      Found in server-for-test/karma-server.js by eslint

                      Disallow process.exit() (no-process-exit)

                      The process.exit() method in Node.js is used to immediately stop the Node.js process and exit. This is a dangerous operation because it can occur in any method at any point in time, potentially stopping a Node.js application completely when an error occurs. For example:

                      if (somethingBadHappened) {
                          console.error("Something bad happened!");
                          process.exit(1);
                      }

                      This code could appear in any module and will stop the entire application when somethingBadHappened is truthy. This doesn't give the application any chance to respond to the error. It's usually better to throw an error and allow the application to handle it appropriately:

                      if (somethingBadHappened) {
                          throw new Error("Something bad happened!");
                      }

                      By throwing an error in this way, other parts of the application have an opportunity to handle the error rather than stopping the application altogether. If the error bubbles all the way up to the process without being handled, then the process will exit and a non-zero exit code will returned, so the end result is the same.

                      Rule Details

                      This rule aims to prevent the use of process.exit() in Node.js JavaScript. As such, it warns whenever process.exit() is found in code.

                      Examples of incorrect code for this rule:

                      /*eslint no-process-exit: "error"*/
                      
                      process.exit(1);
                      process.exit(0);

                      Examples of correct code for this rule:

                      /*eslint no-process-exit: "error"*/
                      
                      Process.exit();
                      var exit = process.exit;

                      When Not To Use It

                      There may be a part of a Node.js application that is responsible for determining the correct exit code to return upon exiting. In that case, you should turn this rule off to allow proper handling of the exit code. Source: http://eslint.org/docs/rules/

                      Unnecessary semicolon.
                      Open

                      };
                      Severity: Minor
                      Found in best-globals.js by eslint

                      disallow unnecessary semicolons (no-extra-semi)

                      Typing mistakes and misunderstandings about where semicolons are required can lead to semicolons that are unnecessary. While not technically an error, extra semicolons can cause confusion when reading code.

                      Rule Details

                      This rule disallows unnecessary semicolons.

                      Examples of incorrect code for this rule:

                      /*eslint no-extra-semi: "error"*/
                      
                      var x = 5;;
                      
                      function foo() {
                          // code
                      };

                      Examples of correct code for this rule:

                      /*eslint no-extra-semi: "error"*/
                      
                      var x = 5;
                      
                      var foo = function() {
                          // code
                      };

                      When Not To Use It

                      If you intentionally use extra semicolons then you can disable this rule.

                      Related Rules

                      Severity
                      Category
                      Status
                      Source
                      Language