Sign upLogin

codenautas/sql-tools

View on GitHub
Star

Showing 8 of 8 total issues

Function sqlsUpserts has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

SqlTools.structuredData.sqlsUpserts = function sqlsUpserts(data, structureData, parentData, parentStructureData, inheritedPks){
    var childQueries = [];
    var fields = [];
    var values = [];
    for(var key in data){
Severity: Major
Found in bin/sql-tools.js - About 2 hrs to fix

    Function sqlRead has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    SqlTools.structuredData.sqlRead = function sqlRead(pk, structuredData, globalInfo, inheritedKeys, parentStructure){
    var outer=!globalInfo;
    if(!globalInfo){
        globalInfo={parameterCount:0, parameterValues:[]};
    }
    Severity: Minor
    Found in bin/sql-tools.js - About 1 hr to fix

      Function sqlsDeletes has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      SqlTools.structuredData.sqlsDeletes = function sqlsDeletes(data, structuredData, queriesArray, parentPks){
    if(structuredData.childTables && structuredData.childTables.length){
        structuredData.childTables.forEach(function(childTable){
            var childPksIndex={};
            Object.assign(childPksIndex, parentPks);
      Severity: Minor
      Found in bin/sql-tools.js - About 1 hr to fix

        Function sqlsUpserts has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        SqlTools.structuredData.sqlsUpserts = function sqlsUpserts(data, structureData, parentData, parentStructureData, inheritedPks){
        Severity: Minor
        Found in bin/sql-tools.js - About 35 mins to fix

          Function sqlRead has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          SqlTools.structuredData.sqlRead = function sqlRead(pk, structuredData, globalInfo, inheritedKeys, parentStructure){
          Severity: Minor
          Found in bin/sql-tools.js - About 35 mins to fix

            Function codenautasModuleDefinition has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            (function codenautasModuleDefinition(root, name, factory) {
    /* global define */
    /* istanbul ignore next */
    if(typeof root.globalModuleName !== 'string'){
        root.globalModuleName = name;
            Severity: Minor
            Found in bin/sql-tools.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            SqlTools.quoteIdentArray = function(dbObjectNameArray){
    return dbObjectNameArray.map(function(value){ return SqlTools.quoteIdent(value); })
    
}
            Severity: Minor
            Found in bin/sql-tools.js and 1 other location - About 30 mins to fix
            bin/sql-tools.js on lines 112..114

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            SqlTools.quoteLiteralArray = function(dbAnyValueArray){
    return dbAnyValueArray.map(function(value){ return SqlTools.quoteLiteral(value); })
}
            Severity: Minor
            Found in bin/sql-tools.js and 1 other location - About 30 mins to fix
            bin/sql-tools.js on lines 107..110

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language