codenothing/CSSCompressor

View on GitHub

Showing 254 of 254 total issues

Avoid too many return statements within this function.
Open

                        return true;
Severity: Major
Found in demo/rules/js/jquery.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return jQuery.isNaN( ret ) ? orig : ret;
    Severity: Major
    Found in demo/rules/js/jquery.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return rootjQuery.ready( selector );
      Severity: Major
      Found in demo/rules/js/jquery.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return this.css( type, typeof size === "string" ? size : size + "px" );
        Severity: Major
        Found in demo/rules/js/jquery.js - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if ( a.selector.length && b.selector.length ) {
                          return a.selector == b.selector ? 0 :
                              a.selector > b.selector ? 1 : -1;
                      }
                      else {
          Severity: Minor
          Found in lib/rules/Sort Multi Selectors.js and 1 other location - About 30 mins to fix
          lib/Rules.js on lines 63..70

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if ( a.priority === b.priority ) {
                          return a.added === b.added ? 0 :
                              a.added > b.added ? 1 :
                              -1;
                      }
          Severity: Minor
          Found in lib/Rules.js and 1 other location - About 30 mins to fix
          lib/rules/Sort Multi Selectors.js on lines 56..62

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                                  if ( options.output ) {
                                      fs.writeFileSync( options.output, sheet, 'utf8' );
                                  }
                                  else {
                                      console.log( sheet );
          Severity: Minor
          Found in lib/Cli.js and 1 other location - About 30 mins to fix
          lib/Cli.js on lines 100..105

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                          if ( options.output ) {
                              fs.writeFileSync( options.output, sheet, 'utf8' );
                          }
                          else {
                              console.log( sheet );
          Severity: Minor
          Found in lib/Cli.js and 1 other location - About 30 mins to fix
          lib/Cli.js on lines 129..134

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function callback has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              callback: function( branch, compressor ) {
                  if ( ! branch.rules || ! branch.rules.length ) {
                      return;
                  }
          
          
          Severity: Minor
          Found in lib/rules/Border, Outline Style Combinations.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function compress has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              compress: function( css, options ) {
                  var self = this, now = Date.now();
          
                  // Clear result
                  self.css = '';
          Severity: Minor
          Found in lib/CSSCompressor.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function callback has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              callback: function( branch, compressor ) {
                  if ( ! branch.atrule || ! branch.parts.length || ( branch.rules && branch.rules.length > 0 ) ) {
                      return;
                  }
          
          
          Severity: Minor
          Found in lib/rules/Atrule URL Trim.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function callback has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              callback: function( branch, compressor ) {
                  if ( ! branch.rules || ! branch.rules.length ) {
                      return;
                  }
          
          
          Severity: Minor
          Found in lib/rules/Empty Values.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function callback has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              callback: function( rule, branch, compressor ) {
                  if ( ! rfontfamilyprop.exec( rule.property ) || ! rule.parts || ! rule.parts.length ) {
                      return;
                  }
          
          
          Severity: Minor
          Found in lib/rules/Font Family Quotes.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function rulesMatch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              rulesMatch = function( a, b ) {
                  if ( ! a || ! b || a.length !== b.length ) {
                      return false;
                  }
          
          
          Severity: Minor
          Found in lib/rules/Common Rules.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language