codenothing/CSSTree

View on GitHub

Showing 30 of 30 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                    if ( rule.position ) {
                        rule.highlight = "Range [" + rule.position.range.start + "," + rule.position.range.end + "]";
                    }
Severity: Major
Found in demo/js.js and 1 other location - About 1 hr to fix
demo/js.js on lines 17..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            if ( c == '/' && iter.next == '*' ) {
                iter.reverse();
                position.markChunkEnd( iter.index );
                self.comment( true );
                position.markChunkStart( iter.index + 1 );
Severity: Major
Found in lib/CSSTree.js and 2 other locations - About 1 hr to fix
lib/CSSTree.js on lines 138..166
lib/CSSTree.js on lines 211..237

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            if ( c == '/' && iter.next == '*' ) {
                iter.reverse();
                parentPos.markChunkEnd( iter.index );
                self.comment( true );
                parentPos.markChunkStart( iter.index + 1 );
Severity: Major
Found in lib/CSSTree.js and 2 other locations - About 1 hr to fix
lib/CSSTree.js on lines 180..197
lib/CSSTree.js on lines 211..237

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            if ( c == '/' && iter.next == '*' ) {
                iter.reverse();
                position.markChunkEnd( iter.index );
                self.comment( true );
                position.markChunkStart( iter.index + 1 );
Severity: Major
Found in lib/CSSTree.js and 2 other locations - About 1 hr to fix
lib/CSSTree.js on lines 138..166
lib/CSSTree.js on lines 180..197

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function rules has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    rules: function( parentPos ) {
        var self = this,
            iter = self.iter,
            rules = [],
            rule, position;
Severity: Minor
Found in lib/CSSTree.js - About 1 hr to fix

    Function value has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        value: function( position ) {
            var self = this,
                iter = self.iter,
                value = '';
    
    
    Severity: Minor
    Found in lib/CSSTree.js - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                      for ( ; ++i < l; ) {
                          c = value[ i ];
                          part += c;
      
                          // End char found, break off and attach part
      Severity: Major
      Found in lib/Rule.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            if ( ! block.rules ) {
                                block.rules = [];
                            }
        Severity: Major
        Found in lib/CSSTree.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              for ( ; ++i < l; ) {
                                  c = selector[ i ];
                                  part += c;
          
                                  if ( c == "\\" ) {
          Severity: Major
          Found in lib/Selector.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                if ( c == seek ) {
                                    break;
                                }
                                // Skip over escaped values
                                else if ( c == "\\" && atrule[ i + 1 ] ) {
            Severity: Major
            Found in lib/AtRule.js - About 45 mins to fix
              Severity
              Category
              Status
              Source
              Language