Sign upLogin

codevise/pageflow

View on GitHub
Star
entry_types/paged/packages/pageflow-paged-react/src/components/__spec__/PageThumbnail-spec.jsx

Summary

Maintainability
D
1 day
Test Coverage

File PageThumbnail-spec.jsx has 302 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import {PageThumbnail} from '../PageThumbnail';

import fileExistsFn from 'support/fileExistsFn';
import {shallow} from 'enzyme';
Severity: Minor
Found in entry_types/paged/packages/pageflow-paged-react/src/components/__spec__/PageThumbnail-spec.jsx - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        const props = {
      page: {
        imageId: 5,
        backgroundType: 'video'
      },
    Severity: Major
    Found in entry_types/paged/packages/pageflow-paged-react/src/components/__spec__/PageThumbnail-spec.jsx and 1 other location - About 3 hrs to fix
    entry_types/paged/packages/pageflow-paged-react/src/components/__spec__/PageThumbnail-spec.jsx on lines 197..220

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 97.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        const props = {
      page: {
        imageId: 5,
        backgroundType: 'image'
      },
    Severity: Major
    Found in entry_types/paged/packages/pageflow-paged-react/src/components/__spec__/PageThumbnail-spec.jsx and 1 other location - About 3 hrs to fix
    entry_types/paged/packages/pageflow-paged-react/src/components/__spec__/PageThumbnail-spec.jsx on lines 228..251

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 97.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        const props = {
      page: {
        imageId: 5,
        backgroundType: 'image'
      },
    Severity: Major
    Found in entry_types/paged/packages/pageflow-paged-react/src/components/__spec__/PageThumbnail-spec.jsx and 1 other location - About 2 hrs to fix
    entry_types/paged/packages/pageflow-paged-react/src/components/__spec__/PageThumbnail-spec.jsx on lines 137..159

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 92.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        const props = {
      page: {
        imageId: 5,
        backgroundType: 'video'
      },
    Severity: Major
    Found in entry_types/paged/packages/pageflow-paged-react/src/components/__spec__/PageThumbnail-spec.jsx and 1 other location - About 2 hrs to fix
    entry_types/paged/packages/pageflow-paged-react/src/components/__spec__/PageThumbnail-spec.jsx on lines 167..189

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 92.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status