codevise/pageflow

View on GitHub
entry_types/scrolled/lib/pageflow_scrolled/seeds.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method create_files has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def create_files(draft_entry, file_type, file_data_by_name, skip_encoding = false)
      file_data_by_name.transform_values do |data|
        say("     creating #{file_type} file from #{data['url']}")

        file_state = %i[image text_track].include?(file_type) ? 'processed' : 'uploading'
Severity: Minor
Found in entry_types/scrolled/lib/pageflow_scrolled/seeds.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sample_scrolled_entry has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def sample_scrolled_entry(attributes:, options: {})
      entry = Pageflow::Entry.where(type_name: 'scrolled')
                             .where(attributes.slice(:account, :title))
                             .first

Severity: Minor
Found in entry_types/scrolled/lib/pageflow_scrolled/seeds.rb - About 1 hr to fix

    Method create_files has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def create_files(draft_entry, file_type, file_data_by_name, skip_encoding = false)
          file_data_by_name.transform_values do |data|
            say("     creating #{file_type} file from #{data['url']}")
    
            file_state = %i[image text_track].include?(file_type) ? 'processed' : 'uploading'
    Severity: Minor
    Found in entry_types/scrolled/lib/pageflow_scrolled/seeds.rb - About 1 hr to fix

      Method rewrite_file_references! has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def rewrite_file_references!(hash, keys, files_by_name)
            return unless hash
      
            keys.each do |key|
              next unless hash[key]
      Severity: Minor
      Found in entry_types/scrolled/lib/pageflow_scrolled/seeds.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status