Sign upLogin

codevise/pageflow

View on GitHub
Star
lib/pageflow/zencoder_video_output_definition.rb

Summary

Maintainability
C
1 day
Test Coverage

File zencoder_video_output_definition.rb has 438 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Pageflow
  class ZencoderVideoOutputDefinition < ZencoderOutputDefinition
    cattr_accessor :skip_hls, :skip_smil

    attr_reader :video_file
Severity: Minor
Found in lib/pageflow/zencoder_video_output_definition.rb - About 6 hrs to fix

    Class ZencoderVideoOutputDefinition has 35 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class ZencoderVideoOutputDefinition < ZencoderOutputDefinition
    cattr_accessor :skip_hls, :skip_smil

    attr_reader :video_file
    Severity: Minor
    Found in lib/pageflow/zencoder_video_output_definition.rb - About 4 hrs to fix

      Method smil_definitions has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def smil_definitions
      return [] if skip_smil

      smil_definition = {
        type: 'playlist',
      Severity: Minor
      Found in lib/pageflow/zencoder_video_output_definition.rb - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def mp4_fullhd_definition
      {
        label: 'fullhd',
        prepare_for_segmenting: ['hls', 'dash'],
        path: video_file.mp4_fullhd.path,
        Severity: Minor
        Found in lib/pageflow/zencoder_video_output_definition.rb and 1 other location - About 25 mins to fix
        lib/pageflow/zencoder_video_output_definition.rb on lines 41..54

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 29.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def mp4_4k_definition
      {
        label: '4k',
        prepare_for_segmenting: ['hls', 'dash'],
        path: video_file.mp4_4k.path,
        Severity: Minor
        Found in lib/pageflow/zencoder_video_output_definition.rb and 1 other location - About 25 mins to fix
        lib/pageflow/zencoder_video_output_definition.rb on lines 58..71

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 29.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status