Sign upLogin

coding-blocks/CBOnlineApp

View on GitHub
Star
app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt

Summary

Maintainability
D
2 days
Test Coverage

Method onBindViewHolder has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    override fun onBindViewHolder(holder: RecyclerView.ViewHolder, position: Int) {
        when (type) {
            LibraryTypes.NOTESVIDEO -> {
                (holder as NoteVideoViewHolder).apply {
                    bind(getItem(position) as NotesModel)
Severity: Minor
Found in app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt - About 1 hr to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                LibraryTypes.DOWNLOADS -> {
                (holder as DownloadViewHolder).apply {
                    tracker?.let {
                        val item = getItem(position) as ContentLecture
                        bind(item, it.isSelected(item.lectureId))
    Severity: Major
    Found in app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt and 2 other locations - About 1 hr to fix
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 84..92
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 93..101

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 143.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                LibraryTypes.NOTE -> {
                (holder as NoteViewHolder).apply {
                    tracker?.let {
                        val item = getItem(position) as NotesModel
                        bind(item, it.isSelected(item.nttUid))
    Severity: Major
    Found in app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt and 2 other locations - About 1 hr to fix
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 93..101
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 103..111

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 143.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                LibraryTypes.BOOKMARK -> {
                (holder as BookmarkViewHolder).apply {
                    tracker?.let {
                        val item = getItem(position) as BookmarkModel
                        bind(item, it.isSelected(item.bookmarkUid))
    Severity: Major
    Found in app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt and 2 other locations - About 1 hr to fix
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 84..92
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 103..111

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 143.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            fun getItemDetails(): ItemDetailsLookup.ItemDetails<String> =
            object : ItemDetailsLookup.ItemDetails<String>() {
                override fun getPosition(): Int = adapterPosition
                override fun getSelectionKey(): String? = (getItem(adapterPosition) as ContentLecture).lectureId
            }
    Severity: Major
    Found in app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt and 2 other locations - About 1 hr to fix
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 131..135
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 175..179

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 139.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            fun getItemDetails(): ItemDetailsLookup.ItemDetails<String> =
            object : ItemDetailsLookup.ItemDetails<String>() {
                override fun getPosition(): Int = adapterPosition
                override fun getSelectionKey(): String? = (getItem(adapterPosition) as BookmarkModel).bookmarkUid
            }
    Severity: Major
    Found in app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt and 2 other locations - About 1 hr to fix
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 131..135
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 200..204

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 139.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            fun getItemDetails(): ItemDetailsLookup.ItemDetails<String> =
            object : ItemDetailsLookup.ItemDetails<String>() {
                override fun getPosition(): Int = adapterPosition
                override fun getSelectionKey(): String? = (getItem(adapterPosition) as NotesModel).nttUid
            }
    Severity: Major
    Found in app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt and 2 other locations - About 1 hr to fix
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 175..179
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 200..204

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 139.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

                is ContentLecture -> if (newItem is ContentLecture) oldItem.lectureId == newItem.lectureId else false
    Severity: Major
    Found in app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt and 4 other locations - About 30 mins to fix
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 211..211
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 212..212
    app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/SectionItemsAdapter.kt on lines 61..61
    app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/SectionItemsAdapter.kt on lines 62..62

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

                is BookmarkModel -> if (newItem is BookmarkModel) oldItem.bookmarkUid == newItem.bookmarkUid else false
    Severity: Major
    Found in app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt and 4 other locations - About 30 mins to fix
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 211..211
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 213..213
    app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/SectionItemsAdapter.kt on lines 61..61
    app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/SectionItemsAdapter.kt on lines 62..62

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

                is NotesModel -> if (newItem is NotesModel) oldItem.nttUid == newItem.nttUid else false
    Severity: Major
    Found in app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt and 4 other locations - About 30 mins to fix
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 212..212
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 213..213
    app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/SectionItemsAdapter.kt on lines 61..61
    app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/SectionItemsAdapter.kt on lines 62..62

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                LibraryTypes.BOOKMARK -> BookmarkViewHolder(
                inflater.inflate(R.layout.item_bookmark, parent, false)
            )
    Severity: Major
    Found in app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt and 3 other locations - About 30 mins to fix
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 59..61
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 62..64
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 68..70

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                LibraryTypes.DOWNLOADS -> DownloadViewHolder(
                inflater.inflate(R.layout.item_download, parent, false)
            )
    Severity: Major
    Found in app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt and 3 other locations - About 30 mins to fix
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 59..61
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 62..64
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 65..67

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                LibraryTypes.NOTESVIDEO -> NoteVideoViewHolder(
                inflater.inflate(R.layout.item_note_player, parent, false)
            )
    Severity: Major
    Found in app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt and 3 other locations - About 30 mins to fix
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 62..64
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 65..67
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 68..70

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                LibraryTypes.NOTE -> NoteViewHolder(
                inflater.inflate(R.layout.item_note, parent, false)
            )
    Severity: Major
    Found in app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt and 3 other locations - About 30 mins to fix
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 59..61
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 65..67
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryListAdapter.kt on lines 68..70

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status