Sign upLogin

coding-blocks/CBOnlineApp

View on GitHub
Star
app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseRepository.kt

Summary

Maintainability
F
5 days
Test Coverage

Method insertContents has a Cognitive Complexity of 156 (exceeds 20 allowed). Consider refactoring.
Open

    private suspend fun insertContents(
        contentList: List<LectureContent>,
        attemptId: String,
        sectionId: String,
        name: String?
Severity: Minor
Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseRepository.kt - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method insertContents has 166 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private suspend fun insertContents(
        contentList: List<LectureContent>,
        attemptId: String,
        sectionId: String,
        name: String?
Severity: Major
Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseRepository.kt - About 6 hrs to fix

    File MyCourseRepository.kt has 323 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    package com.codingblocks.cbonlineapp.mycourse

import com.codingblocks.cbonlineapp.database.BookmarkDao
import com.codingblocks.cbonlineapp.database.ContentDao
import com.codingblocks.cbonlineapp.database.CourseWithInstructorDao
    Severity: Minor
    Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseRepository.kt - About 3 hrs to fix

      Class MyCourseRepository has 26 methods (exceeds 20 allowed). Consider refactoring.
      Open

      class MyCourseRepository(
    private val sectionWithContentsDao: SectionWithContentsDao,
    private val contentsDao: ContentDao,
    private val sectionDao: SectionDao,
    private val courseWithInstructorDao: CourseWithInstructorDao,
      Severity: Minor
      Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseRepository.kt - About 3 hrs to fix

        Method insertSections has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring.
        Open

            suspend fun insertSections(runAttempt: RunAttempts, refresh: Boolean = false) {
        val runAttemptModel = RunAttemptModel(
            runAttempt.id,
            runAttempt.certificateApproved,
            runAttempt.end,
        Severity: Minor
        Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseRepository.kt - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method insertSections has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            suspend fun insertSections(runAttempt: RunAttempts, refresh: Boolean = false) {
        val runAttemptModel = RunAttemptModel(
            runAttempt.id,
            runAttempt.certificateApproved,
            runAttempt.end,
        Severity: Minor
        Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseRepository.kt - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              suspend fun saveStats(body: PerformanceResponse, id: String) {
        runPerformanceDao.insert(
            RunPerformance(
                id,
                body.performance?.percentile ?: 0,
          Severity: Major
          Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseRepository.kt and 1 other location - About 1 hr to fix
          app/src/main/java/com/codingblocks/cbonlineapp/dashboard/home/DashboardHomeRepository.kt on lines 36..46

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 132.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (oldModel != null && !oldModel.sameAndEqual(newContent)) {
                contentsDao.update(newContent)
            } else {
                contentsDao.insertNew(
                    newContent
          Severity: Minor
          Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseRepository.kt and 1 other location - About 55 mins to fix
          app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/codechallenge/CodeChallengeRepository.kt on lines 109..115

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 86.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              suspend fun unPauseCourse(id: String?) = safeApiCall {
        checkNotNull(id) { "RunAttempt Id cannot be null" }
        CBOnlineLib.onlineV2JsonApi.unPauseCourse(id)
    }
          Severity: Minor
          Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseRepository.kt and 1 other location - About 55 mins to fix
          app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseRepository.kt on lines 344..347

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 83.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              suspend fun pauseCourse(id: String?) = safeApiCall {
        checkNotNull(id) { "RunAttempt Id cannot be null" }
        CBOnlineLib.onlineV2JsonApi.pauseCourse(id)
    }
          Severity: Minor
          Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseRepository.kt and 1 other location - About 55 mins to fix
          app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseRepository.kt on lines 349..352

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 83.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              suspend fun sendFeedback(id: String, feedback: SendFeedback) = safeApiCall { CBOnlineLib.api.sendFeedback(id, feedback) }
          Severity: Major
          Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseRepository.kt and 3 other locations - About 40 mins to fix
          app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/codechallenge/CodeChallengeRepository.kt on lines 23..23
          app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/player/VideoPlayerRepository.kt on lines 31..31
          app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/player/VideoPlayerRepository.kt on lines 33..33

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 72.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status