Sign upLogin

coding-blocks/CBOnlineApp

View on GitHub
Star
app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseViewModel.kt

Summary

Maintainability
D
2 days
Test Coverage

Method getPerformance has a Cognitive Complexity of 36 (exceeds 20 allowed). Consider refactoring.
Open

    private fun getPerformance() {
        runIO {
            val mRank = repo.getHackerBlocksPerformance().value
            when (val response = repo.getPerformance()) {
                is ResultWrapper.GenericError -> setError(response.error)
Severity: Minor
Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseViewModel.kt - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File MyCourseViewModel.kt has 282 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package com.codingblocks.cbonlineapp.mycourse

import android.app.DownloadManager
import android.content.Context
import android.net.Uri
Severity: Minor
Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseViewModel.kt - About 2 hrs to fix

    Method getStats has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
    Open

        fun getStats() {
        runIO {
            when (val response = attemptId?.let { repo.getStats(it) }) {
                is ResultWrapper.GenericError -> setError(response.error)
                is ResultWrapper.Success -> with(response.value) {
    Severity: Minor
    Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseViewModel.kt - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getLeaderboard has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
    Open

        fun getLeaderboard() = liveData(Dispatchers.IO) {
        when (val response = repo.fetchLeaderboard(runId!!)) {
            is ResultWrapper.GenericError -> setError(response.error)
            is ResultWrapper.Success -> with(response.value) {
                if (isSuccessful) {
    Severity: Minor
    Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseViewModel.kt - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        fun pauseCourse() = liveData {
        when (val response = repo.pauseCourse(attemptId)) {
            is ResultWrapper.GenericError -> setError(response.error)
            is ResultWrapper.Success -> with(response.value) {
                if (isSuccessful) {
    Severity: Major
    Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseViewModel.kt and 1 other location - About 3 hrs to fix
    app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseViewModel.kt on lines 268..280

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 209.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        fun unPauseCourse() = liveData {
        when (val response = repo.unPauseCourse(attemptId)) {
            is ResultWrapper.GenericError -> setError(response.error)
            is ResultWrapper.Success -> with(response.value) {
                if (isSuccessful) {
    Severity: Major
    Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseViewModel.kt and 1 other location - About 3 hrs to fix
    app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseViewModel.kt on lines 254..266

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 209.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        fun updateRunAttempt() {
        runIO {
            when (val response = attemptId?.let { repo.fetchSections(it) }) {
                is ResultWrapper.GenericError -> setError(response.error)
                is ResultWrapper.Success -> with(response.value) {
    Severity: Major
    Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseViewModel.kt and 1 other location - About 2 hrs to fix
    app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseViewModel.kt on lines 186..195

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 181.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        fun requestMentorApproval() {
        runIO {
            when (val response = attemptId?.let { repo.requestApproval(it) }) {
                is ResultWrapper.GenericError -> setError(response.error)
                is ResultWrapper.Success -> with(response.value) {
    Severity: Major
    Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseViewModel.kt and 1 other location - About 2 hrs to fix
    app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseViewModel.kt on lines 197..206

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 181.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

            val request: OneTimeWorkRequest =
            OneTimeWorkRequestBuilder<ProgressWorker>()
                .setConstraints(constraints)
                .setInputData(progressData)
                .setBackoffCriteria(BackoffPolicy.EXPONENTIAL, 20, TimeUnit.SECONDS)
    Severity: Major
    Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseViewModel.kt and 6 other locations - About 1 hr to fix
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryViewModel.kt on lines 111..116
    app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/player/VideoPlayerActivity.kt on lines 327..332
    app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/player/VideoPlayerViewModel.kt on lines 206..211
    app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/player/VideoPlayerViewModel.kt on lines 335..340
    app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/player/VideoPlayerViewModel.kt on lines 349..354
    app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/player/VideoPlayerViewModel.kt on lines 371..376

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 103.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        val performance: LiveData<RunPerformance>? by lazy {
        attemptId?.let { repo.getRunStats(it) }
    }
    Severity: Major
    Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseViewModel.kt and 2 other locations - About 50 mins to fix
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryViewModel.kt on lines 42..44
    app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseViewModel.kt on lines 85..87

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 79.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        val run: LiveData<CourseRunPair>? by lazy {
        attemptId?.let { repo.getRunById(it) }
    }
    Severity: Major
    Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseViewModel.kt and 2 other locations - About 50 mins to fix
    app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryViewModel.kt on lines 42..44
    app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseViewModel.kt on lines 81..83

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 79.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status