Sign upLogin

coding-blocks/CBOnlineApp

View on GitHub
Star
app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/codechallenge/CodeChallengeRepository.kt

Summary

Maintainability
C
1 day
Test Coverage

Method saveCode has a Cognitive Complexity of 50 (exceeds 20 allowed). Consider refactoring.
Open

    suspend fun saveCode(codeId: String, codeChallenge: CodeChallenge) {
        val newCode: CodeChallengeModel = codeId.let {

            with(codeChallenge.content!!) {
                CodeChallengeModel(
Severity: Minor
Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/codechallenge/CodeChallengeRepository.kt - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method saveCode has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    suspend fun saveCode(codeId: String, codeChallenge: CodeChallenge) {
        val newCode: CodeChallengeModel = codeId.let {

            with(codeChallenge.content!!) {
                CodeChallengeModel(
Severity: Minor
Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/codechallenge/CodeChallengeRepository.kt - About 1 hr to fix

    Method getOfflineContent has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        suspend fun getOfflineContent(codeId: String): CodeChallenge? {
        val model: CodeChallengeModel? = codeDao.getCodeChallengeById(codeId)

        val challenge = with(model!!) {
            CodeChallenge(
    Severity: Minor
    Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/codechallenge/CodeChallengeRepository.kt - About 1 hr to fix

      Identical blocks of code found in 4 locations. Consider refactoring.
      Open

          suspend fun updateBookmark(bookmark: Bookmark) {
        bookmarkDao.insert(
            BookmarkModel(
                bookmark.id ?: "",
                bookmark.runAttempt?.id ?: "",
      Severity: Major
      Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/codechallenge/CodeChallengeRepository.kt and 3 other locations - About 1 hr to fix
      app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/document/PdfActivityRepository.kt on lines 16..26
      app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/player/VideoPlayerRepository.kt on lines 99..109
      app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/quiz/QuizRepository.kt on lines 32..42

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 144.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (oldModel != null && !oldModel.sameAndEqual(newCode)) {
            codeDao.update(newCode)
        } else {
            codeDao.insertNew(
                newCode
      Severity: Minor
      Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/codechallenge/CodeChallengeRepository.kt and 1 other location - About 55 mins to fix
      app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseRepository.kt on lines 276..282

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 86.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          suspend fun fetchCodeChallenge(codeId: Int, contestId: String) = safeApiCall { CBOnlineLib.onlineV2JsonApi.getCodeChallenge(codeId, contestId) }
      Severity: Major
      Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/codechallenge/CodeChallengeRepository.kt and 3 other locations - About 40 mins to fix
      app/src/main/java/com/codingblocks/cbonlineapp/mycourse/MyCourseRepository.kt on lines 354..354
      app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/player/VideoPlayerRepository.kt on lines 31..31
      app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/player/VideoPlayerRepository.kt on lines 33..33

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status