File ViewExtensions.kt
has 493 lines of code (exceeds 250 allowed). Consider refactoring. Open
package com.codingblocks.cbonlineapp.util.extensions
import android.animation.Animator
import android.animation.AnimatorListenerAdapter
import android.content.Context
Method showDialog
has 52 lines of code (exceeds 25 allowed). Consider refactoring. Open
fun Context.showDialog(
type: String,
cancelable: Boolean = false,
@DrawableRes image: Int = R.drawable.ic_lock,
@StringRes primaryText: Int = R.string.confirmation,
Method colouriseToolbar
has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring. Open
fun Toolbar.colouriseToolbar(context: Context, @DrawableRes toolbarDrawable: Int, @ColorInt foregroundColor: Int) {
background = AppCompatResources.getDrawable(context, toolbarDrawable)
setTitleTextColor(foregroundColor)
setSubtitleTextColor(foregroundColor)
val colorFilter = PorterDuffColorFilter(foregroundColor, PorterDuff.Mode.SRC_IN)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method crossfade
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
fun View.crossfade(view: View, otherView: View?, type: Int = View.INVISIBLE) {
this.apply {
// Set the content view to 0% opacity but visible, so that it is visible
// (but fully transparent) during the animation.
if (otherView == null && !isVisible) {
Method animateVisibility
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
fun View.animateVisibility(visible: Int) {
if (visible == View.VISIBLE) {
visibility = View.VISIBLE
alpha = 0f
scaleX = 0f
Method replaceFragmentSafely
has 9 arguments (exceeds 4 allowed). Consider refactoring. Open
fragment: Fragment,
tag: String = "",
allowStateLoss: Boolean = false,
@IdRes containerViewId: Int,
@AnimRes enterAnimation: Int = 0,
Method replaceFragmentSafely
has 9 arguments (exceeds 4 allowed). Consider refactoring. Open
fragment: Fragment,
tag: String = "",
allowStateLoss: Boolean = false,
@IdRes containerViewId: Int,
@AnimatorRes enterAnimation: Int = R.animator.slide_in_left,
Method colouriseToolbar
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
fun Toolbar.colouriseToolbar(context: Context, @DrawableRes toolbarDrawable: Int, @ColorInt foregroundColor: Int) {
background = AppCompatResources.getDrawable(context, toolbarDrawable)
setTitleTextColor(foregroundColor)
setSubtitleTextColor(foregroundColor)
val colorFilter = PorterDuffColorFilter(foregroundColor, PorterDuff.Mode.SRC_IN)
Method showDialog
has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
type: String,
cancelable: Boolean = false,
@DrawableRes image: Int = R.drawable.ic_lock,
@StringRes primaryText: Int = R.string.confirmation,
@StringRes secondaryText: Int = R.string.unavailable,
Method showSnackbar
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
message: String,
length: Int = Snackbar.LENGTH_SHORT,
anchorView: BottomNavigationView? = null,
action: Boolean = true,
actionText: String = "Retry",
Method setRv
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
activity: Context,
listAdapter: ListAdapter<out Any, out RecyclerView.ViewHolder>,
setDivider: Boolean = false,
type: String = "",
orientation: Int = RecyclerView.VERTICAL,
Avoid deeply nested control flow statements. Open
for (k in drawables.indices) {
val drawable = drawables[k]
if (drawable != null) {
innerView.post { innerView.compoundDrawables[k].colorFilter = colorFilter }
}
Method setToolbar
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
toolbar: Toolbar,
hasUpEnabled: Boolean = true,
homeButtonEnabled: Boolean = true,
title: String = "",
show: Boolean = true
Method changeViewState
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
recyclerView: RecyclerView,
internetView: LinearLayout,
emptyView: LinearLayout,
shimmerView: ShimmerFrameLayout,
boolean: Boolean
Similar blocks of code found in 2 locations. Consider refactoring. Open
anim.addListener(object : AnimatorListenerAdapter() {
override fun onAnimationEnd(animation: Animator) {
super.onAnimationEnd(animation)
it.visibility = type
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 91.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
anim.addListener(object : AnimatorListenerAdapter() {
override fun onAnimationEnd(animation: Animator) {
super.onAnimationEnd(animation)
view.visibility = type
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 91.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
dialog.apply {
window?.setBackgroundDrawableResource(android.R.color.transparent)
setView(view)
setCancelable(cancelable)
show()
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 81.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
dialog.apply {
window?.setBackgroundDrawableResource(android.R.color.transparent)
setView(view)
setCancelable(cancelable)
show()
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 81.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
} else if (view.mobile.editText?.text.isNullOrEmpty() && view.mobile.editText?.text?.length!! < 10) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 72.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76