Sign upLogin

coding-chimp/onesignal

View on GitHub
Star
lib/onesignal/models/player_notification_target.rb

Summary

Maintainability
D
2 days
Test Coverage

Method initialize has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

    def initialize(attributes = {})
      if (!attributes.is_a?(Hash))
        fail ArgumentError, "The input argument (attributes) must be a hash in `OneSignal::PlayerNotificationTarget` initialize method"
      end
Severity: Minor
Found in lib/onesignal/models/player_notification_target.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def initialize(attributes = {})
      if (!attributes.is_a?(Hash))
        fail ArgumentError, "The input argument (attributes) must be a hash in `OneSignal::PlayerNotificationTarget` initialize method"
      end
Severity: Major
Found in lib/onesignal/models/player_notification_target.rb - About 2 hrs to fix

    File player_notification_target.rb has 270 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'date'
require 'time'

module OneSignal
  class PlayerNotificationTarget
    Severity: Minor
    Found in lib/onesignal/models/player_notification_target.rb - About 2 hrs to fix

      Method _deserialize has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def _deserialize(type, value)
      case type.to_sym
      when :Time
        Time.parse(value)
      when :Date
      Severity: Minor
      Found in lib/onesignal/models/player_notification_target.rb - About 1 hr to fix

        Method build_from_hash has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            def build_from_hash(attributes)
      return nil unless attributes.is_a?(Hash)
      attributes = attributes.transform_keys(&:to_sym)
      self.class.openapi_types.each_pair do |key, type|
        if attributes[self.class.attribute_map[key]].nil? && self.class.openapi_nullable.include?(key)
        Severity: Minor
        Found in lib/onesignal/models/player_notification_target.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method _deserialize has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            def _deserialize(type, value)
      case type.to_sym
      when :Time
        Time.parse(value)
      when :Date
        Severity: Minor
        Found in lib/onesignal/models/player_notification_target.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method to_hash has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def to_hash
      hash = {}
      self.class.attribute_map.each_pair do |attr, param|
        value = self.send(attr)
        if value.nil?
        Severity: Minor
        Found in lib/onesignal/models/player_notification_target.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method _to_hash has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def _to_hash(value)
      if value.is_a?(Array)
        value.compact.map { |v| _to_hash(v) }
      elsif value.is_a?(Hash)
        {}.tap do |hash|
        Severity: Minor
        Found in lib/onesignal/models/player_notification_target.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 14 locations. Consider refactoring.
        Open

            class EnumAttributeValidator
      attr_reader :datatype
      attr_reader :allowable_values

      def initialize(datatype, allowable_values)
        Severity: Major
        Found in lib/onesignal/models/player_notification_target.rb and 13 other locations - About 35 mins to fix
        lib/onesignal/models/app.rb on lines 107..126
        lib/onesignal/models/basic_notification.rb on lines 326..345
        lib/onesignal/models/basic_notification_all_of.rb on lines 286..305
        lib/onesignal/models/filter.rb on lines 30..49
        lib/onesignal/models/filter_expressions.rb on lines 33..52
        lib/onesignal/models/get_notification_request_body.rb on lines 26..45
        lib/onesignal/models/notification.rb on lines 329..348
        lib/onesignal/models/notification_target.rb on lines 58..77
        lib/onesignal/models/notification_with_meta.rb on lines 357..376
        lib/onesignal/models/operator.rb on lines 21..40
        lib/onesignal/models/outcome_data.rb on lines 24..43
        lib/onesignal/models/subscription_object.rb on lines 52..71
        lib/onesignal/models/update_live_activity_request.rb on lines 28..47

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 34.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def self.openapi_types
      {
        :'include_player_ids' => :'Array<String>',
        :'include_external_user_ids' => :'Array<String>',
        :'include_email_tokens' => :'Array<String>',
        Severity: Minor
        Found in lib/onesignal/models/player_notification_target.rb and 1 other location - About 20 mins to fix
        lib/onesignal/models/player_notification_target.rb on lines 75..88

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def self.attribute_map
      {
        :'include_player_ids' => :'include_player_ids',
        :'include_external_user_ids' => :'include_external_user_ids',
        :'include_email_tokens' => :'include_email_tokens',
        Severity: Minor
        Found in lib/onesignal/models/player_notification_target.rb and 1 other location - About 20 mins to fix
        lib/onesignal/models/player_notification_target.rb on lines 98..111

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status